- Notifications
You must be signed in to change notification settings - Fork28
Commit20064c0
committed
Handle ALTER EXTENSION ADD/DROP with pg_init_privs
In commit6c268df, pg_init_privs was added to track the initialprivileges of catalog objects and extensions. Unfortunately, thatcommit didn't include understanding of ALTER EXTENSION ADD/DROP, whichallows the objects associated with an extension to be changed after theinitial CREATE EXTENSION script has been run.The result of this meant that ACLs for objects added throughALTER EXTENSION ADD were not recorded into pg_init_privs and we wouldend up including those ACLs in pg_dump when we shouldn't have.This commit corrects that by making sure to have pg_init_privs updatedwhen ALTER EXTENSION ADD/DROP is run, recording the permissions as theyare at ALTER EXTENSION ADD time, and removing any if/when ALTEREXTENSION DROP is called.This issue was pointed out by Moshe Jacobson as commentary on bug #14456(which was actually a bug about versions prior to 9.6 not handlingcustom ACLs on extensions correctly, an issue now addressed withpg_init_privs in 9.6).Back-patch to 9.6 where pg_init_privs was introduced.1 parent73cd489 commit20064c0
File tree
6 files changed
+732
-29
lines changed- src
- backend
- catalog
- commands
- include/utils
- test/modules/test_pg_dump
- expected
- sql
- t
6 files changed
+732
-29
lines changed0 commit comments
Comments
(0)