NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit1fbb6c9

committed

Fix platform-specific performance regression in logtape.c.

Commit24d8595 made a change that indirectly caused a performanceregression by triggering a change in the way GCC optimizes memcpy() onsome platforms.The behavior seemed to contradict a GCC document, so I filed a report:https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95556This patch implements a narrow workaround which eliminates theregression I observed. The workaround is benign enough that it seemsunlikely to cause a different regression on another platform.Discussion:https://postgr.es/m/99b2eab335c1592c925d8143979c8e9e81e1575f.camel@j-davis.com

1 parentaa79276 commit1fbb6c9Copy full SHA for 1fbb6c9

File tree

1 file changed

-1

lines changed

src/backend/utils/sort
- logtape.c

1 file changed

-1

lines changed

`‎src/backend/utils/sort/logtape.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -782,7 +782,7 @@ LogicalTapeWrite(LogicalTapeSet *lts, int tapenum,`
`782`	`782`	`Assert(lt->buffer_size==BLCKSZ);`
`783`	`783`	`while (size>0)`
`784`	`784`	`{`
`785`		`-if (lt->pos >=TapeBlockPayloadSize)`
	`785`	`+if (lt->pos >=(int)TapeBlockPayloadSize)`
`786`	`786`	`{`
`787`	`787`	`/* Buffer full, dump it out */`
`788`	`788`	`longnextBlockNumber;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1fbb6c9

File tree

1 file changed

1 file changed

`‎src/backend/utils/sort/logtape.c`

0 commit comments