Commit1f35944

committed

In pg_upgrade, clean up handling of invalid directory specification by

checking the stat() errno value more strictly.

1 parent772a5f1 commit1f35944Copy full SHA for 1f35944

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -70,9 +70,9 @@ is_server_running(const char *datadir)`
`70`	`70`
`71`	`71`	`if ((fd=open(path,O_RDONLY,0))<0)`
`72`	`72`	`{`
`73`		`-if (errno!=ENOENT)`
`74`		`-/* issue a warning but continue so we can throw a clearer error later */`
`75`		`-pg_log(PG_WARNING,"could not open file \"%s\" for reading\n",`
	`73`	`+/* ENOTDIR means we will throw a more useful error later */`
	`74`	`+if (errno!=ENOENT&&errno!=ENOTDIR)`
	`75`	`+pg_log(PG_FATAL,"could not open file \"%s\" for reading\n",`
`76`	`76`	`path);`
`77`	`77`
`78`	`78`	`return false;`

Comments

(0)