Commit1b9dea0

committed

Remove useless 'needlock' argument from GetXLogInsertRecPtr. It was always

passed as 'true'.

1 parent9c808f8 commit1b9dea0Copy full SHA for 1b9dea0

File tree

-7

lines changed

-7

lines changed

Lines changed: 3 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -9411,16 +9411,14 @@ GetStandbyFlushRecPtr(void)`
`9411`	`9411`	`* Get latest WAL insert pointer`
`9412`	`9412`	`*/`
`9413`	`9413`	`XLogRecPtr`
`9414`		`-GetXLogInsertRecPtr(boolneedlock)`
	`9414`	`+GetXLogInsertRecPtr(void)`
`9415`	`9415`	`{`
`9416`	`9416`	`XLogCtlInsert*Insert=&XLogCtl->Insert;`
`9417`	`9417`	`XLogRecPtrcurrent_recptr;`
`9418`	`9418`
`9419`		`-if (needlock)`
`9420`		`-LWLockAcquire(WALInsertLock,LW_SHARED);`
	`9419`	`+LWLockAcquire(WALInsertLock,LW_SHARED);`
`9421`	`9420`	`INSERT_RECPTR(current_recptr,Insert,Insert->curridx);`
`9422`		`-if (needlock)`
`9423`		`-LWLockRelease(WALInsertLock);`
	`9421`	`+LWLockRelease(WALInsertLock);`
`9424`	`9422`
`9425`	`9423`	`returncurrent_recptr;`
`9426`	`9424`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ pg_current_xlog_insert_location(PG_FUNCTION_ARGS)`
`200`	`200`	`errmsg("recovery is in progress"),`
`201`	`201`	`errhint("WAL control functions cannot be executed during recovery.")));`
`202`	`202`
`203`		`-current_recptr=GetXLogInsertRecPtr(true);`
	`203`	`+current_recptr=GetXLogInsertRecPtr();`
`204`	`204`
`205`	`205`	`snprintf(location,sizeof(location),"%X/%X",`
`206`	`206`	`current_recptr.xlogid,current_recptr.xrecoff);`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ extern bool XLogInsertAllowed(void);`
`288`	`288`	`externvoidGetXLogReceiptTime(TimestampTzrtime,boolfromStream);`
`289`	`289`	`externXLogRecPtrGetXLogReplayRecPtr(XLogRecPtr*restoreLastRecPtr);`
`290`	`290`	`externXLogRecPtrGetStandbyFlushRecPtr(void);`
`291`		`-externXLogRecPtrGetXLogInsertRecPtr(boolneedlock);`
	`291`	`+externXLogRecPtrGetXLogInsertRecPtr(void);`
`292`	`292`	`externXLogRecPtrGetXLogWriteRecPtr(void);`
`293`	`293`	`externboolRecoveryIsPaused(void);`
`294`	`294`	`externvoidSetRecoveryPause(boolrecoveryPause);`

Comments

(0)