Commit1a40d37

committed

Fix typos and improve incremental sort comments

1 parent7b48f1b commit1a40d37Copy full SHA for 1a40d37

File tree

+10

-8

lines changed

+10

-8

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2869,7 +2869,7 @@ show_incremental_sort_group_info(IncrementalSortGroupInfo *groupInfo,`
`2869`	`2869`	`}`
`2870`	`2870`
`2871`	`2871`	`/*`
`2872`		`- * If it's EXPLAIN ANALYZE, show tuplesort stats fora incremental sort node`
	`2872`	`+ * If it's EXPLAIN ANALYZE, show tuplesort stats foran incremental sort node`
`2873`	`2873`	`*/`
`2874`	`2874`	`staticvoid`
`2875`	`2875`	`show_incremental_sort_info(IncrementalSortState*incrsortstate,`
`@@ -2917,7 +2917,7 @@ show_incremental_sort_info(IncrementalSortState *incrsortstate,`
`2917`	`2917`	`&incrsortstate->shared_info->sinfo[n];`
`2918`	`2918`
`2919`	`2919`	`/*`
`2920`		`- * If a worker hasn'tprocess any sort groups at all, then exclude`
	`2920`	`+ * If a worker hasn'tprocessed any sort groups at all, then exclude`
`2921`	`2921`	`* it from output since it either didn't launch or didn't`
`2922`	`2922`	`* contribute anything meaningful.`
`2923`	`2923`	`*/`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1152,8 +1152,10 @@ ExecReScanIncrementalSort(IncrementalSortState *node)`
`1152`	`1152`	`/*`
`1153`	`1153`	`* If we've set up either of the sort states yet, we need to reset them.`
`1154`	`1154`	`* We could end them and null out the pointers, but there's no reason to`
`1155`		`- * repay the setup cost, and because guard setting up pivot comparator`
`1156`		`- * state similarly, doing so might actually cause a leak.`
	`1155`	`+ * repay the setup cost, and because ExecIncrementalSort guards`
	`1156`	`+ * presorted column functions by checking to see if the full sort state`
	`1157`	`+ * has been initialized yet, setting the sort states to null here might`
	`1158`	`+ * actually cause a leak.`
`1157`	`1159`	`*/`
`1158`	`1160`	`if (node->fullsort_state!=NULL)`
`1159`	`1161`	`{`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1428,11 +1428,11 @@ tuplesort_updatemax(Tuplesortstate *state)`
`1428`	`1428`	`}`
`1429`	`1429`
`1430`	`1430`	`/*`
`1431`		`- * Sort evicts data to the disk when itdidn'tmanage to fitthose datato`
`1432`		`- *themain memory. This is why we assume space used on the disk to be`
	`1431`	`+ * Sort evicts data to the disk when itwasn'table to fitthat datainto`
	`1432`	`+ * main memory. This is why we assume space used on the disk to be`
`1433`	`1433`	`* more important for tracking resource usage than space used in memory.`
`1434`		`- * Note that amount of space occupied by sometuple set on the disk might`
`1435`		`- * be less than amount of space occupied by the sametuple set in the`
	`1434`	`+ * Note thattheamount of space occupied by sometupleset on the disk might`
	`1435`	`+ * be less than amount of space occupied by the sametupleset in`
`1436`	`1436`	`* memory due to more compact representation.`
`1437`	`1437`	`*/`
`1438`	`1438`	`if ((isSpaceDisk&& !state->isMaxSpaceDisk)\|\|`

Comments

(0)