Commit1983af8

committed

Switch some palloc/memset calls to palloc0

Some code paths have been doing some allocations followed by animmediate memset() to initialize the allocated area with zeros, this isa bit overkill as there are already interfaces to do both things in onecall.Author: Daniel GustafssonReviewed-by: Michael PaquierDiscussion:https://postgr.es/m/vN0OodBPkKs7g2Z1uyk3CUEmhdtspHgYCImhlmSxv1Xn6nY1ZnaaGHL8EWUIQ-NEv36tyc4G5-uA3UXUF2l4sFXtK_EQgLN1hcgunlFVKhA=@yesql.se

1 parent5bde165 commit1983af8Copy full SHA for 1983af8

File tree

-13

lines changed

-13

lines changed

Lines changed: 2 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -867,11 +867,8 @@ get_crosstab_tuplestore(char *sql,`
`867`	`867`	`"tuple has %d columns but crosstab " \`
`868`	`868`	`"returns %d.",tupdesc->natts,result_ncols)));`
`869`	`869`
`870`		`-/* allocate space */`
`871`		`-values= (char*)palloc(result_ncolssizeof(char*));`
`872`		`-`
`873`		`-/* and make sure it's clear */`
`874`		`-memset(values,'\0',result_ncolssizeof(char));`
	`870`	`+/* allocate space and make sure it's clear */`
	`871`	`+values= (char*)palloc0(result_ncolssizeof(char*));`
`875`	`872`
`876`	`873`	`for (i=0;i<proc;i++)`
`877`	`874`	`{`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,7 @@ static void gistprunepage(Relation rel, Page page, Buffer buffer,`
`43`	`43`
`44`	`44`
`45`	`45`	`#defineROTATEDIST(d) do { \`
`46`		`-SplitedPageLayout tmp=(SplitedPageLayout)palloc(sizeof(SplitedPageLayout)); \`
`47`		`-memset(tmp,0,sizeof(SplitedPageLayout)); \`
	`46`	`+SplitedPageLayout tmp=(SplitedPageLayout)palloc0(sizeof(SplitedPageLayout)); \`
`48`	`47`	`tmp->block.blkno = InvalidBlockNumber;\`
`49`	`48`	`tmp->buffer = InvalidBuffer;\`
`50`	`49`	`tmp->next = (d); \`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1382,8 +1382,7 @@ SortTocFromFile(Archive *AHX)`
`1382`	`1382`	`boolincomplete_line;`
`1383`	`1383`
`1384`	`1384`	`/* Allocate space for the 'wanted' array, and init it */`
`1385`		`-ropt->idWanted= (bool)pg_malloc(sizeof(bool)AH->maxDumpId);`
`1386`		`-memset(ropt->idWanted,0,sizeof(bool)*AH->maxDumpId);`
	`1385`	`+ropt->idWanted= (bool)pg_malloc0(sizeof(bool)AH->maxDumpId);`
`1387`	`1386`
`1388`	`1387`	`/* Setup the file */`
`1389`	`1388`	`fh=fopen(ropt->tocFile,PG_BINARY_R);`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -320,8 +320,7 @@ TopoSort(DumpableObject **objs,`
`320`	`320`	`* We also make a map showing the input-order index of the item with`
`321`	`321`	`* dumpId j.`
`322`	`322`	`*/`
`323`		`-beforeConstraints= (int)pg_malloc((maxDumpId+1)sizeof(int));`
`324`		`-memset(beforeConstraints,0, (maxDumpId+1)*sizeof(int));`
	`323`	`+beforeConstraints= (int)pg_malloc0((maxDumpId+1)sizeof(int));`
`325`	`324`	`idMap= (int)pg_malloc((maxDumpId+1)sizeof(int));`
`326`	`325`	`for (i=0;i<numObjs;i++)`
`327`	`326`	`{`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5301,8 +5301,7 @@ main(int argc, char **argv)`
`5301`	`5301`	`elseif ((env=getenv("PGUSER"))!=NULL&&*env!='\0')`
`5302`	`5302`	`login=env;`
`5303`	`5303`
`5304`		`-state= (CState*)pg_malloc(sizeof(CState));`
`5305`		`-memset(state,0,sizeof(CState));`
	`5304`	`+state= (CState*)pg_malloc0(sizeof(CState));`
`5306`	`5305`
`5307`	`5306`	`/* set random seed early, because it may be used while parsing scripts. */`
`5308`	`5307`	`if (!set_random_seed(getenv("PGBENCH_RANDOM_SEED")))`

Comments

(0)