NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit1943c00

committed

initdb -S should now have an explicit check that $PGDATA is valid.

The fsync code from the backend essentially assumes that somebody's alreadyvalidated PGDATA, at least to the extent of it being a readable directory.That's safe enough for initdb's normal code path too, but "initdb -S"doesn't have any other processing at all that touches the target directory.To have reasonable error-case behavior, add a pg_check_dir call.Per gripe from Peter E.

1 parent57e1138 commit1943c00Copy full SHA for 1943c00

File tree

1 file changed

+10

-1

lines changed

src/bin/initdb
- initdb.c

1 file changed

+10

-1

lines changed

`‎src/bin/initdb/initdb.c`

Lines changed: 10 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3564,10 +3564,19 @@ main(int argc, char *argv[])`
`3564`	`3564`	`exit(1);`
`3565`	`3565`	`}`
`3566`	`3566`
`3567`		`-/* If we only need to fsync, justto it and exit */`
	`3567`	`+/* If we only need to fsync, justdo it and exit */`
`3568`	`3568`	`if (sync_only)`
`3569`	`3569`	`{`
`3570`	`3570`	`setup_pgdata();`
	`3571`	`+`
	`3572`	`+/* must check that directory is readable */`
	`3573`	`+if (pg_check_dir(pg_data) <=0)`
	`3574`	`+{`
	`3575`	`+fprintf(stderr,_("%s: could not access directory \"%s\": %s\n"),`
	`3576`	`+progname,pg_data,strerror(errno));`
	`3577`	`+exit_nicely();`
	`3578`	`+}`
	`3579`	`+`
`3571`	`3580`	`fsync_pgdata();`
`3572`	`3581`	`return0;`
`3573`	`3582`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1943c00

File tree

1 file changed

1 file changed

`‎src/bin/initdb/initdb.c`

0 commit comments