NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit17742a0

committed

Fix broken error check in _hash_doinsert.

You can't just cast a HashMetaPage to a Page, because the meta pagedata is stored after the page header, not at offset 0. Fortunately,this didn't break anything because it happens to find hashm_bsizeat the offset at which it expects to find pd_pagesize_version, andthe values are close enough to the same that this works out.Still, it's a bug, so back-patch to all supported versions.Mithun Cy, revised a bit by me.

1 parent51126cc commit17742a0Copy full SHA for 17742a0

File tree

1 file changed

-3

lines changed

src/backend/access/hash
- hashinsert.c

1 file changed

-3

lines changed

`‎src/backend/access/hash/hashinsert.c`

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ _hash_doinsert(Relation rel, IndexTuple itup)`
`34`	`34`	`BlockNumberblkno;`
`35`	`35`	`BlockNumberoldblkno=InvalidBlockNumber;`
`36`	`36`	`boolretry= false;`
	`37`	`+Pagemetapage;`
`37`	`38`	`Pagepage;`
`38`	`39`	`HashPageOpaquepageopaque;`
`39`	`40`	`Sizeitemsz;`
`@@ -53,7 +54,8 @@ _hash_doinsert(Relation rel, IndexTuple itup)`
`53`	`54`
`54`	`55`	`/* Read the metapage */`
`55`	`56`	`metabuf=_hash_getbuf(rel,HASH_METAPAGE,HASH_READ,LH_META_PAGE);`
`56`		`-metap=HashPageGetMeta(BufferGetPage(metabuf));`
	`57`	`+metapage=BufferGetPage(metabuf);`
	`58`	`+metap=HashPageGetMeta(metapage);`
`57`	`59`
`58`	`60`	`/*`
`59`	`61`	`* Check whether the item can fit on a hash page at all. (Eventually, we`
`@@ -62,11 +64,11 @@ _hash_doinsert(Relation rel, IndexTuple itup)`
`62`	`64`	`*`
`63`	`65`	`* XXX this is useless code if we are only storing hash keys.`
`64`	`66`	`*/`
`65`		`-if (itemsz>HashMaxItemSize((Page)metap))`
	`67`	`+if (itemsz>HashMaxItemSize(metapage))`
`66`	`68`	`ereport(ERROR,`
`67`	`69`	`(errcode(ERRCODE_PROGRAM_LIMIT_EXCEEDED),`
`68`	`70`	`errmsg("index row size %zu exceeds hash maximum %zu",`
`69`		`-itemsz,HashMaxItemSize((Page)metap)),`
	`71`	`+itemsz,HashMaxItemSize(metapage)),`
`70`	`72`	`errhint("Values larger than a buffer page cannot be indexed.")));`
`71`	`73`
`72`	`74`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit17742a0

File tree

1 file changed

1 file changed

`‎src/backend/access/hash/hashinsert.c`

0 commit comments