Commit1685267

Arthur Zakirov

committed

Some comments

1 parentda84306 commit1685267Copy full SHA for 1685267

File tree

+12

-15

lines changed

+12

-15

lines changed

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,15 @@ endif`
`35`	`35`	`wal-check: temp-install`
`36`	`36`	`$(prove_check)`
`37`	`37`
	`38`	`+all: rum--1.1.sql`
	`39`	`+`
	`40`	`+#9.6 requires 1.1 file but 10.0 could live with 1.0 + 1.0-1.1 files`
	`41`	`+rum--1.1.sql: rum--1.0.sql rum--1.0--1.1.sql`
	`42`	`+cat rum--1.0.sql rum--1.0--1.1.sql> rum--1.1.sql`
	`43`	`+`
	`44`	`+rum--1.0--1.1.sql: Makefile gen_rum_sql--1.0--1.1.pl`
	`45`	`+perl gen_rum_sql--1.0--1.1.pl> rum--1.0--1.1.sql`
	`46`	`+`
`38`	`47`	`install: installincludes`
`39`	`48`
`40`	`49`	`installincludes:`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -702,12 +702,12 @@ typedef struct RumScanOpaqueData`
`702`	`702`	`intnorderbys;/* Number of columns in ordering.`
`703`	`703`	`Will be assigned to sortstate->nKeys */`
`704`	`704`
`705`		`-RumItemitem;`
	`705`	`+RumItemitem;/* current item used in index scan */`
`706`	`706`	`boolfirstCall;`
	`707`	`+`
`707`	`708`	`boolisVoidRes;/* true if query is unsatisfiable */`
`708`		`-boolwillSort;`
	`709`	`+boolwillSort;/* is there any columns in ordering */`
`709`	`710`	`RumScanTypescanType;`
`710`		`-TIDBitmap*tbm;`
`711`	`711`
`712`	`712`	`ScanDirectionnaturalOrder;`
`713`	`713`	`boolsecondPass;`

Lines changed: 0 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -2044,17 +2044,6 @@ rumgetbitmap(IndexScanDesc scan, TIDBitmap *tbm)`
`2044`	`2044`
`2045`	`2045`	`ntids=0;`
`2046`	`2046`
`2047`		`-/*`
`2048`		`- * First, scan the pending list and collect any matching entries into the`
`2049`		`- * bitmap. After we scan a pending item, some other backend could post it`
`2050`		`- * into the main index, and so we might visit it a second time during the`
`2051`		`- * main scan. This is okay because we'll just re-set the same bit in the`
`2052`		`- * bitmap. (The possibility of duplicate visits is a major reason why RUM`
`2053`		`- * can't support the amgettuple API, however.) Note that it would not do`
`2054`		`- * to scan the main index before the pending list, since concurrent`
`2055`		`- * cleanup could then make us miss entries entirely.`
`2056`		`- */`
`2057`		`-so->tbm=tbm;`
`2058`	`2047`	`so->entriesIncrIndex=-1;`
`2059`	`2048`
`2060`	`2049`	`/*`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -534,7 +534,6 @@ rumNewScanKey(IndexScanDesc scan)`
`534`	`534`
`535`	`535`	`so->naturalOrder=NoMovementScanDirection;`
`536`	`536`	`so->secondPass= false;`
`537`		`-so->tbm=NULL;`
`538`	`537`	`so->entriesIncrIndex=-1;`
`539`	`538`	`so->norderbys=scan->numberOfOrderBys;`
`540`	`539`	`so->willSort= false;`

Comments

(0)