NotificationsYou must be signed in to change notification settings
Fork28
Star153

Commit141e878

Neil Conway

committed

Trivial dead code removal: in makeObjectName(), name1 must be non-NULL

(due to the preceding strlen(), for example), so we needn't recheck thisbefore invoking pg_mbcliplen().Per Coverity static analysis performed by EnterpriseDB.

1 parent638feae commit141e878Copy full SHA for 141e878

File tree

1 file changed

-3

lines changed

src/backend/commands
- indexcmds.c

1 file changed

-3

lines changed

`‎src/backend/commands/indexcmds.c‎`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.131 2005/05/06 17:24:53 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.132 2005/06/21 00:35:05 neilc Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -760,8 +760,7 @@ makeObjectName(const char name1, const char name2, const char *label)`
`760`	`760`	`name2chars--;`
`761`	`761`	`}`
`762`	`762`
`763`		`-if (name1)`
`764`		`-name1chars=pg_mbcliplen(name1,name1chars,name1chars);`
	`763`	`+name1chars=pg_mbcliplen(name1,name1chars,name1chars);`
`765`	`764`	`if (name2)`
`766`	`765`	`name2chars=pg_mbcliplen(name2,name2chars,name2chars);`
`767`	`766`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit141e878

File tree

1 file changed

1 file changed

`‎src/backend/commands/indexcmds.c‎`

0 commit comments