Commit13ab195

committed

document (in comments) why only pass-by-value allowed to orderby column

1 parente33dac2 commit13ab195Copy full SHA for 13ab195

File tree

+12

-1

lines changed

+12

-1

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,11 @@ callConsistentFn(RumState *rumstate, RumScanKey key)`
`92`	`92`	`if (key->entryRes[i]&&key->addInfoIsNull[0]== false)`
`93`	`93`	`{`
`94`	`94`	`key->outerAddInfoIsNull= false;`
`95`		`-/* XXX FIXME only pass-by-value!!! */`
	`95`	`+/*`
	`96`	`+ * XXX FIXME only pass-by-value!!!`
	`97`	`+ * Value should be copied to long-lived memory context and,`
	`98`	`+ * somehow, freeed. Seems, the last is real problem`
	`99`	`+ */`
`96`	`100`	`key->outerAddInfo=key->addInfo[0];`
`97`	`101`	`break;`
`98`	`102`	`}`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -333,6 +333,13 @@ initRumState(RumState *state, Relation index)`
`333`	`333`	`else`
`334`	`334`	`state->supportCollation[i]=DEFAULT_COLLATION_OID;`
`335`	`335`	`}`
	`336`	`+`
	`337`	`+if (AttributeNumberIsValid(state->attrnOrderByColumn))`
	`338`	`+{`
	`339`	`+/* Follow FIXME comment(s) to understand */`
	`340`	`+if (origTupdesc->attrs[state->attrnOrderByColumn-1]->attbyval== false)`
	`341`	`+elog(ERROR,"currently, RUM doesn't support order by over pass-by-reference column");`
	`342`	`+}`
`336`	`343`	`}`
`337`	`344`
`338`	`345`	`/*`

Comments

(0)