NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit1377b40

committed

Fix uninitialized-variable bug.

map_partition_varattnos() failed to set its found_whole_row outputparameter if the given expression list was NIL. This seems to bea pre-existing bug that chanced to be exposed by commit6f6b99d.It might be unreachable in v10, but I have little faith in thatproposition, so back-patch.Per buildfarm.

1 parent5f0ac02 commit1377b40Copy full SHA for 1377b40

File tree

1 file changed

+15

-13

lines changed

src/backend/catalog
- partition.c

1 file changed

+15

-13

lines changed

`‎src/backend/catalog/partition.c`

Lines changed: 15 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -916,21 +916,23 @@ map_partition_varattnos(List *expr, int target_varno,`
`916`	`916`	`Relationpartrel,Relationparent,`
`917`	`917`	`bool*found_whole_row)`
`918`	`918`	`{`
`919`		`-AttrNumber*part_attnos;`
`920`		`-boolmy_found_whole_row;`
	`919`	`+boolmy_found_whole_row= false;`
`921`	`920`
`922`		`-if (expr==NIL)`
`923`		`-returnNIL;`
	`921`	`+if (expr!=NIL)`
	`922`	`+{`
	`923`	`+AttrNumber*part_attnos;`
	`924`	`+`
	`925`	`+part_attnos=convert_tuples_by_name_map(RelationGetDescr(partrel),`
	`926`	`+RelationGetDescr(parent),`
	`927`	`+gettext_noop("could not convert row type"));`
	`928`	`+expr= (List)map_variable_attnos((Node)expr,`
	`929`	`+target_varno,0,`
	`930`	`+part_attnos,`
	`931`	`+RelationGetDescr(parent)->natts,`
	`932`	`+RelationGetForm(partrel)->reltype,`
	`933`	`+&my_found_whole_row);`
	`934`	`+}`
`924`	`935`
`925`		`-part_attnos=convert_tuples_by_name_map(RelationGetDescr(partrel),`
`926`		`-RelationGetDescr(parent),`
`927`		`-gettext_noop("could not convert row type"));`
`928`		`-expr= (List)map_variable_attnos((Node)expr,`
`929`		`-target_varno,0,`
`930`		`-part_attnos,`
`931`		`-RelationGetDescr(parent)->natts,`
`932`		`-RelationGetForm(partrel)->reltype,`
`933`		`-&my_found_whole_row);`
`934`	`936`	`if (found_whole_row)`
`935`	`937`	`*found_whole_row=my_found_whole_row;`
`936`	`938`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1377b40

File tree

1 file changed

1 file changed

`‎src/backend/catalog/partition.c`

0 commit comments