NotificationsYou must be signed in to change notification settings
Fork28
Star153

Commit117fde2

Neil Conway

committed

Minor ecpg tweak: the return value of calloc() is guaranteed to be NULL

or zero-filled; therefore zero-filling it via memset() is pointless.(I think setting `errno' is probably a waste of cycles as well, but Ihaven't changed that.)

1 parent4802bb5 commit117fde2Copy full SHA for 117fde2

File tree

1 file changed

-5

lines changed

src/interfaces/ecpg/pgtypeslib
- common.c

1 file changed

-5

lines changed

`‎src/interfaces/ecpg/pgtypeslib/common.c‎`

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,18 +2,14 @@`
`2`	`2`
`3`	`3`	`#include"extern.h"`
`4`	`4`
	`5`	`+/* Return value is zero-filled. */`
`5`	`6`	`char*`
`6`	`7`	`pgtypes_alloc(longsize)`
`7`	`8`	`{`
`8`	`9`	`charnew= (char)calloc(1L,size);`
`9`	`10`
`10`	`11`	`if (!new)`
`11`		`-{`
`12`	`12`	`errno=ENOMEM;`
`13`		`-returnNULL;`
`14`		`-}`
`15`		`-`
`16`		`-memset(new,'\0',size);`
`17`	`13`	`return (new);`
`18`	`14`	`}`
`19`	`15`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit117fde2

File tree

1 file changed

1 file changed

`‎src/interfaces/ecpg/pgtypeslib/common.c‎`

0 commit comments