Commit107cbc9

committed

Fix variable names mentioned in comment to match the code.

Also, in another comment, explain why holding an insertion slot is acritical section.Per review by Amit Kapila.

1 parent59c02a3 commit107cbc9Copy full SHA for 107cbc9

File tree

-3

lines changed

-3

lines changed

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1322,8 +1322,8 @@ ReserveXLogInsertLocation(int size, XLogRecPtr StartPos, XLogRecPtr EndPos,`
`1322`	`1322`	`*`
`1323`	`1323`	`* A log-switch record is handled slightly differently. The rest of the`
`1324`	`1324`	`* segment will be reserved for this insertion, as indicated by the returned`
`1325`		`- * *EndPos_p value. However, if we are already at the beginning of the current`
`1326`		`- * segment, StartPos_p and EndPos_p are set to the current location without`
	`1325`	`+ * *EndPos value. However, if we are already at the beginning of the current`
	`1326`	`+ * segment, StartPos and EndPos are set to the current location without`
`1327`	`1327`	`* reserving any space, and the function returns false.`
`1328`	`1328`	`*/`
`1329`	`1329`	`staticbool`
`@@ -1575,7 +1575,9 @@ WALInsertSlotAcquireOne(int slotno)`
`1575`	`1575`	`/*`
`1576`	`1576`	`* Lock out cancel/die interrupts until we exit the code section protected`
`1577`	`1577`	`* by the slot. This ensures that interrupts will not interfere with`
`1578`		`- * manipulations of data structures in shared memory.`
	`1578`	`+ * manipulations of data structures in shared memory. There is no cleanup`
	`1579`	`+ * mechanism to release the slot if the backend dies while holding one,`
	`1580`	`+ * so make this a critical section.`
`1579`	`1581`	`*/`
`1580`	`1582`	`START_CRIT_SECTION();`
`1581`	`1583`

Comments

(0)