NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit0dcc73f

committed

Ensure xmlFree(NULL) is a no-op instead of a core dump. Per report from

Sergey Burladyan, there are at least some dank corners of libxml2 thatassume this behavior, even though their published documentation suggeststhey shouldn't.This is only really a live problem in 8.3, but the code is still therefor possible debugging use in HEAD, so patch both branches.

1 parentf371fda commit0dcc73fCopy full SHA for 0dcc73f

File tree

1 file changed

-2

lines changed

src/backend/utils/adt
- xml.c

1 file changed

-2

lines changed

`‎src/backend/utils/adt/xml.c`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1996-2009, PostgreSQL Global Development Group`
`8`	`8`	`* Portions Copyright (c) 1994, Regents of the University of California`
`9`	`9`	`*`
`10`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.90 2009/06/09 22:00:57 petere Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.91 2009/06/10 03:44:35 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -1293,7 +1293,9 @@ xml_repalloc(void *ptr, size_t size)`
`1293`	`1293`	`staticvoid`
`1294`	`1294`	`xml_pfree(void*ptr)`
`1295`	`1295`	`{`
`1296`		`-pfree(ptr);`
	`1296`	`+/* At least some parts of libxml assume xmlFree(NULL) is allowed */`
	`1297`	`+if (ptr)`
	`1298`	`+pfree(ptr);`
`1297`	`1299`	`}`
`1298`	`1300`
`1299`	`1301`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0dcc73f

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/xml.c`

0 commit comments