Commit0d9b092

committed

Better error reporting if the link target is too long

This situation won't set errno, so using %m will give an incorrecterror message.

1 parent1f422db commit0d9b092Copy full SHA for 0d9b092

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -287,9 +287,12 @@ pg_tablespace_location(PG_FUNCTION_ARGS)`
`287`	`287`	`*/`
`288`	`288`	`snprintf(sourcepath,sizeof(sourcepath),"pg_tblspc/%u",tablespaceOid);`
`289`	`289`	`rllen=readlink(sourcepath,targetpath,sizeof(targetpath));`
`290`		`-if (rllen<0\|\|rllen >=sizeof(targetpath))`
	`290`	`+if (rllen<0)`
`291`	`291`	`ereport(ERROR,`
`292`	`292`	`(errmsg("could not read symbolic link \"%s\": %m",sourcepath)));`
	`293`	`+elseif (rllen >=sizeof(targetpath))`
	`294`	`+ereport(ERROR,`
	`295`	`+(errmsg("symbolic link \"%s\" target is too long",sourcepath)));`
`293`	`296`	`targetpath[rllen]='\0';`
`294`	`297`
`295`	`298`	`PG_RETURN_TEXT_P(cstring_to_text(targetpath));`

Comments

(0)