Commit0d68ad3

committed

Fix division by zero in _bt_vacuum_needs_cleanup()

Checks inside _bt_vacuum_needs_cleanup() allow division by zero to happen whenmetad->btm_last_cleanup_num_heap_tuples == 0. This commit adjusts theexpression so that no division by zero might happen.Reported-by: Piotr StefaniakDiscussion:https://postgr.es/m/DB8PR03MB5931C41F7787A95313F08322F22A0%40DB8PR03MB5931.eurprd03.prod.outlook.comReviewed-by: Masahiko SawadaBackpatch-through: 11

1 parent5129026 commit0d68ad3Copy full SHA for 0d68ad3

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -833,7 +833,7 @@ _bt_vacuum_needs_cleanup(IndexVacuumInfo *info)`
`833`	`833`	`prev_num_heap_tuples=metad->btm_last_cleanup_num_heap_tuples;`
`834`	`834`
`835`	`835`	`if (cleanup_scale_factor <=0\|\|`
`836`		`-prev_num_heap_tuples<0\|\|`
	`836`	`+prev_num_heap_tuples <=0\|\|`
`837`	`837`	`(info->num_heap_tuples-prev_num_heap_tuples) /`
`838`	`838`	`prev_num_heap_tuples >=cleanup_scale_factor)`
`839`	`839`	`result= true;`

Comments

(0)