NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit075dc25

committed

Fix kill() call in elog() so that it gets its own pid by calling getpid().

MyProcPid global variable is set to 0 when postgres starts as a command(not as a backend daemon). This leads issuing SIGQUIT to the process group,not the process itself. As a result, parent sh gets core dumped in theWisconsin benchmark test.

1 parente062a17 commit075dc25Copy full SHA for 075dc25

File tree

1 file changed

-2

lines changed

src/backend/utils/error
- elog.c

1 file changed

-2

lines changed

`‎src/backend/utils/error/elog.c`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/utils/error/elog.c,v 1.39 1999/02/13 23:19:47 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/error/elog.c,v 1.40 1999/04/16 06:38:17 ishii Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -221,7 +221,11 @@ elog(int lev, const char *fmt,...)`
`221`	`221`	`ProcReleaseSpins(NULL);/* get rid of spinlocks we hold */`
`222`	`222`	`if (!InError)`
`223`	`223`	`{`
`224`		`-kill(MyProcPid,SIGQUIT);/* abort to traffic cop */`
	`224`	`+if (MyProcPid==0) {`
	`225`	`+kill(getpid(),SIGQUIT);`
	`226`	`+}else {`
	`227`	`+kill(MyProcPid,SIGQUIT);/* abort to traffic cop */`
	`228`	`+}`
`225`	`229`	`pause();`
`226`	`230`	`}`
`227`	`231`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit075dc25

File tree

1 file changed

1 file changed

`‎src/backend/utils/error/elog.c`

0 commit comments