Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit0685c5c

Browse files
author
Amit Kapila
committed
Fix memory leak in SnapBuildSerialize.
The memory for the snapshot was leaked while serializing it to disk duringlogical decoding. This memory will be freed only once walsender stopsstreaming the changes. This can lead to a huge memory increase when masterlogs Standby Snapshot too frequently say when the user is trying to createmany replication slots.Reported-by: funnyxj.fxj@alibaba-inc.comDiagnosed-by: funnyxj.fxj@alibaba-inc.comAuthor: Amit KapilaBackpatch-through: 9.5Discussion:https://postgr.es/m/033ab54c-6393-42ee-8ec9-2b399b5d8cde.funnyxj.fxj@alibaba-inc.com
1 parent0011c5a commit0685c5c

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

‎src/backend/replication/logical/snapbuild.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1480,7 +1480,7 @@ static void
14801480
SnapBuildSerialize(SnapBuild*builder,XLogRecPtrlsn)
14811481
{
14821482
Sizeneeded_length;
1483-
SnapBuildOnDisk*ondisk;
1483+
SnapBuildOnDisk*ondisk=NULL;
14841484
char*ondisk_c;
14851485
intfd;
14861486
chartmppath[MAXPGPATH];
@@ -1679,6 +1679,9 @@ SnapBuildSerialize(SnapBuild *builder, XLogRecPtr lsn)
16791679
out:
16801680
ReorderBufferSetRestartPoint(builder->reorder,
16811681
builder->last_serialized_snapshot);
1682+
/* be tidy */
1683+
if (ondisk)
1684+
pfree(ondisk);
16821685
}
16831686

16841687
/*

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp