NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit030ad0a

committed

Add check for syscache lookup failure in update_relispartition().

Omitted in commit05b38c7 (though it looks like the original blamebelongs to9e9befa). A failure is admittedly unlikely, but if itdid happen, SIGSEGV is not the approved method of reporting it.Per Coverity. Back-patch to v11 where the broken code originated.

1 parent506af10 commit030ad0aCopy full SHA for 030ad0a

File tree

1 file changed

-1

lines changed

src/backend/commands
- indexcmds.c

1 file changed

-1

lines changed

`‎src/backend/commands/indexcmds.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2682,10 +2682,11 @@ update_relispartition(Oid relationId, bool newval)`
`2682`	`2682`
`2683`	`2683`	`classRel=heap_open(RelationRelationId,RowExclusiveLock);`
`2684`	`2684`	`tup=SearchSysCacheCopy1(RELOID,ObjectIdGetDatum(relationId));`
	`2685`	`+if (!HeapTupleIsValid(tup))`
	`2686`	`+elog(ERROR,"cache lookup failed for relation %u",relationId);`
`2685`	`2687`	`Assert(((Form_pg_class)GETSTRUCT(tup))->relispartition!=newval);`
`2686`	`2688`	`((Form_pg_class)GETSTRUCT(tup))->relispartition=newval;`
`2687`	`2689`	`CatalogTupleUpdate(classRel,&tup->t_self,tup);`
`2688`	`2690`	`heap_freetuple(tup);`
`2689`		`-`
`2690`	`2691`	`heap_close(classRel,RowExclusiveLock);`
`2691`	`2692`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit030ad0a

File tree

1 file changed

1 file changed

`‎src/backend/commands/indexcmds.c`

0 commit comments