NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitffcf6f4

committed

Fix rare sharedtuplestore.c corruption.

If the final chunk of an oversized tuple being written out to disk wasexactly 32760 bytes, it would be corrupted due to a fencepost bug.Bug #17619. Back-patch to 11 where the code arrived.While testing that (see test module in archives), I (tmunro) noticedthat the per-participant page counter was not initialized to zero as itshould have been; that wasn't a live bug when it was written since DSMmemory was originally always zeroed, but since 14min_dynamic_shared_memory might be configured and it supplies non-zeroedmemory, so that is also fixed here.Author: Dmitry Astapov <dastapov@gmail.com>Discussion:https://postgr.es/m/17619-0de62ceda812b8b5%40postgresql.org

1 parent9aeff09 commitffcf6f4Copy full SHA for ffcf6f4

File tree

1 file changed

-2

lines changed

src/backend/utils/sort
- sharedtuplestore.c

1 file changed

-2

lines changed

`‎src/backend/utils/sort/sharedtuplestore.c`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -158,6 +158,7 @@ sts_initialize(SharedTuplestore *sts, int participants,`
`158`	`158`	`LWLockInitialize(&sts->participants[i].lock,`
`159`	`159`	`LWTRANCHE_SHARED_TUPLESTORE);`
`160`	`160`	`sts->participants[i].read_page=0;`
	`161`	`+sts->participants[i].npages=0;`
`161`	`162`	`sts->participants[i].writing= false;`
`162`	`163`	`}`
`163`	`164`
`@@ -320,7 +321,7 @@ sts_puttuple(SharedTuplestoreAccessor accessor, void meta_data,`
`320`	`321`
`321`	`322`	`/* Do we have space? */`
`322`	`323`	`size=accessor->sts->meta_data_size+tuple->t_len;`
`323`		`-if (accessor->write_pointer+size >=accessor->write_end)`
	`324`	`+if (accessor->write_pointer+size>accessor->write_end)`
`324`	`325`	`{`
`325`	`326`	`if (accessor->write_chunk==NULL)`
`326`	`327`	`{`
`@@ -340,7 +341,7 @@ sts_puttuple(SharedTuplestoreAccessor accessor, void meta_data,`
`340`	`341`	`}`
`341`	`342`
`342`	`343`	`/* It may still not be enough in the case of a gigantic tuple. */`
`343`		`-if (accessor->write_pointer+size >=accessor->write_end)`
	`344`	`+if (accessor->write_pointer+size>accessor->write_end)`
`344`	`345`	`{`
`345`	`346`	`size_twritten;`
`346`	`347`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitffcf6f4

File tree

1 file changed

1 file changed

`‎src/backend/utils/sort/sharedtuplestore.c`

0 commit comments