NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitff28809

committed

Code review for dynahash change.

Commitbe0a666 left behind a comment about the order of some tests thatdidn't make sense without the expensive division, and in fact we mightas well change the order to one that fails more cheaply most of the timeas a micro-optimization. Also, remove the "+ 1" applied to max_bucket,to drop an instruction and match the original behavior. Per reviewfrom Tom Lane.Discussion:https://postgr.es/m/VI1PR0701MB696044FC35013A96FECC7AC8F62D0%40VI1PR0701MB6960.eurprd07.prod.outlook.com

1 parentbe0a666 commitff28809Copy full SHA for ff28809

File tree

1 file changed

-4

lines changed

src/backend/utils/hash
- dynahash.c

1 file changed

-4

lines changed

`‎src/backend/utils/hash/dynahash.c`

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -963,11 +963,10 @@ hash_search_with_hash_value(HTAB *hashp,`
`963`	`963`	`{`
`964`	`964`	`/*`
`965`	`965`	`* Can't split if running in partitioned mode, nor if frozen, nor if`
`966`		`- * table is the subject of any active hash_seq_search scans. Strange`
`967`		`- * order of these tests is to try to check cheaper conditions first.`
	`966`	`+ * table is the subject of any active hash_seq_search scans.`
`968`	`967`	`*/`
`969`		`-if (!IS_PARTITIONED(hctl)&& !hashp->frozen&&`
`970`		`-hctl->freeList[0].nentries> (long) (hctl->max_bucket+1)&&`
	`968`	`+if (hctl->freeList[0].nentries> (long)hctl->max_bucket&&`
	`969`	`+!IS_PARTITIONED(hctl)&& !hashp->frozen&&`
`971`	`970`	`!has_seq_scans(hashp))`
`972`	`971`	`(void)expand_table(hashp);`
`973`	`972`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitff28809

File tree

1 file changed

1 file changed

`‎src/backend/utils/hash/dynahash.c`

0 commit comments