Commitfef2c17

committed

Properly set relpersistence for fake relcache entries.

This can result in buffers failing to be properly flushed atcheckpoint time, leading to data loss.Report, diagnosis, and patch by Jeff Davis.

1 parentdf4234d commitfef2c17Copy full SHA for fef2c17

File tree

-0

lines changed

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -371,6 +371,8 @@ CreateFakeRelcacheEntry(RelFileNode rnode)`
`371`	`371`	`FakeRelCacheEntryfakeentry;`
`372`	`372`	`Relationrel;`
`373`	`373`
	`374`	`+Assert(InRecovery);`
	`375`	`+`
`374`	`376`	`/* Allocate the Relation struct and all related space in one block. */`
`375`	`377`	`fakeentry=palloc0(sizeof(FakeRelCacheEntryData));`
`376`	`378`	`rel= (Relation)fakeentry;`
`@@ -380,6 +382,9 @@ CreateFakeRelcacheEntry(RelFileNode rnode)`
`380`	`382`	`/* We will never be working with temp rels during recovery */`
`381`	`383`	`rel->rd_backend=InvalidBackendId;`
`382`	`384`
	`385`	`+/* It must be a permanent table if we're in recovery. */`
	`386`	`+rel->rd_rel->relpersistence=RELPERSISTENCE_PERMANENT;`
	`387`	`+`
`383`	`388`	`/* We don't know the name of the relation; use relfilenode instead */`
`384`	`389`	`sprintf(RelationGetRelationName(rel),"%u",rnode.relNode);`
`385`	`390`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -269,6 +269,8 @@ ReadBufferWithoutRelcache(RelFileNode rnode, ForkNumber forkNum,`
`269`	`269`
`270`	`270`	`SMgrRelationsmgr=smgropen(rnode,InvalidBackendId);`
`271`	`271`
	`272`	`+Assert(InRecovery);`
	`273`	`+`
`272`	`274`	`returnReadBuffer_common(smgr,RELPERSISTENCE_PERMANENT,forkNum,blockNum,`
`273`	`275`	`mode,strategy,&hit);`
`274`	`276`	`}`

Comments

(0)