forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitfec0778
committed
Clarify the distinction between public and private SPITupleTable fields.
The fields that we consider public are "tupdesc" and "vals", whichhistorically are in the middle of the struct. Move them to the front(this should be perfectly safe to do in HEAD) and add comments to makeit quite clear which fields are public or not.Also adjust spi.sgml's documentation of the struct to match.That doc had bit-rotted somewhat, as it was missing some fields.(Arguably we should just remove all the private fields from the docs,but for now I refrained.)Daniel Gustafsson, reviewed by Fabien CoelhoDiscussion:https://postgr.es/m/0D19F836-B743-4340-B6A2-F148CA3DD1F0@yesql.se1 parent860c095 commitfec0778
2 files changed
+18
-10
lines changedLines changed: 13 additions & 8 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
318 | 318 |
| |
319 | 319 |
| |
320 | 320 |
| |
321 |
| - | |
| 321 | + | |
322 | 322 |
| |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
323 | 328 |
| |
324 |
| - | |
325 |
| - | |
326 |
| - | |
327 |
| - | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
328 | 333 |
| |
329 | 334 |
| |
| 335 | + | |
| 336 | + | |
330 | 337 |
| |
331 | 338 |
| |
332 | 339 |
| |
333 |
| - | |
334 |
| - | |
335 |
| - | |
| 340 | + | |
336 | 341 |
| |
337 | 342 |
| |
338 | 343 |
| |
|
Lines changed: 5 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
21 | 21 |
| |
22 | 22 |
| |
23 | 23 |
| |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
24 | 29 |
| |
25 | 30 |
| |
26 | 31 |
| |
27 |
| - | |
28 |
| - | |
29 | 32 |
| |
30 | 33 |
| |
31 | 34 |
| |
|
0 commit comments
Comments
(0)