NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfebda37

committed

Avoid platform-dependent infinite loop in pg_dump.

If malloc(0) returns NULL, the binary search in findSecLabels() willprobably go into an infinite loop when there are no security labels,because NULL-1 is greater than NULL after wraparound.(We've seen this pathology before ... I wonder whether there's a way todetect the class of bugs automatically?)Diagnosis and patch by Steve Singer, cosmetic adjustments by me

1 parent37e66e7 commitfebda37Copy full SHA for febda37

File tree

1 file changed

-2

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-2

lines changed

`‎src/bin/pg_dump/pg_dump.c‎`

Lines changed: 9 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -643,9 +643,10 @@ main(int argc, char **argv)`
`643`	`643`	`do_sql_command(g_conn,"SET quote_all_identifiers = true");`
`644`	`644`
`645`	`645`	`/*`
`646`		`- * Disables security label support if server version < v9.1.x`
	`646`	`+ * Disable security label support if server version < v9.1.x (prevents`
	`647`	`+ * access to nonexistent pg_seclabel catalog)`
`647`	`648`	`*/`
`648`		`-if (!no_security_labels&&g_fout->remoteVersion<90100)`
	`649`	`+if (g_fout->remoteVersion<90100)`
`649`	`650`	`no_security_labels=1;`
`650`	`651`
`651`	`652`	`/*`
`@@ -11761,6 +11762,12 @@ findSecLabels(Archive fout, Oid classoid, Oid objoid, SecLabelItem *items)`
`11761`	`11762`	`if (nlabels<0)`
`11762`	`11763`	`nlabels=collectSecLabels(fout,&labels);`
`11763`	`11764`
	`11765`	`+if (nlabels <=0)/* no labels, so no match is possible */`
	`11766`	`+{`
	`11767`	`+*items=NULL;`
	`11768`	`+return0;`
	`11769`	`+}`
	`11770`	`+`
`11764`	`11771`	`/*`
`11765`	`11772`	`* Do binary search to find some item matching the object.`
`11766`	`11773`	`*/`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfebda37

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c‎`

0 commit comments