NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfe4f36b

committed

Fix compiler warning

Introduced in0aa8f76.MSVC warned about performing 32-bit bit shifting when it appeared like wemight like a 64-bit result. We did, but it just so happened that none ofthe calls to this function could have caused the 32-bit shift to overflow.Here we just cast the constant to int64 to make the compiler happy.Discussion:https://postgr.es/m/CAApHDvofA_vsrpC13mq_hZyuye5B-ssKEaer04OouXYCO5-uXQ@mail.gmail.com

1 parentf560209 commitfe4f36bCopy full SHA for fe4f36b

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- dbsize.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/dbsize.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -627,7 +627,7 @@ numeric_shift_right(Numeric n, unsigned count)`
`627`	`627`	`Datumdivisor_numeric;`
`628`	`628`	`Datumresult;`
`629`	`629`
`630`		`-divisor_numeric=NumericGetDatum(int64_to_numeric(1 <<count));`
	`630`	`+divisor_numeric=NumericGetDatum(int64_to_numeric(((int64)1) <<count));`
`631`	`631`	`result=DirectFunctionCall2(numeric_div_trunc,d,divisor_numeric);`
`632`	`632`	`returnDatumGetNumeric(result);`
`633`	`633`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfe4f36b

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/dbsize.c`

0 commit comments