Commitfe1b503

committed

Adjust display of actual runtimes in EXPLAIN output to use three fractional

digits, and label it 'ms' not 'msec', for consistency with psql's \timingdisplay. Per recent discussions.

1 parentfa2356a commitfe1b503Copy full SHA for fe1b503

File tree

+12

-12

lines changed

+12

-12

lines changed

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`<!--`
`2`		`-$Header: /cvsroot/pgsql/doc/src/sgml/perform.sgml,v 1.34 2003/10/10 02:08:42 momjian Exp $`
	`2`	`+$Header: /cvsroot/pgsql/doc/src/sgml/perform.sgml,v 1.35 2003/10/17 01:14:26 tgl Exp $`
`3`	`3`	`-->`
`4`	`4`
`5`	`5`	`<chapter id="performance-tips">`
`@@ -284,16 +284,16 @@ EXPLAIN ANALYZE SELECT * FROM tenk1 t1, tenk2 t2 WHERE t1.unique1 < 50 AND t1`
`284`	`284`	`QUERY PLAN`
`285`	`285`	`-------------------------------------------------------------------------------`
`286`	`286`	`Nested Loop (cost=0.00..327.02 rows=49 width=296)`
`287`		`- (actual time=1.18..29.82 rows=50 loops=1)`
	`287`	`+ (actual time=1.181..29.822 rows=50 loops=1)`
`288`	`288`	`-> Index Scan using tenk1_unique1 on tenk1 t1`
`289`	`289`	`(cost=0.00..179.33 rows=49 width=148)`
`290`		`- (actual time=0.63..8.91 rows=50 loops=1)`
	`290`	`+ (actual time=0.630..8.917 rows=50 loops=1)`
`291`	`291`	`Index Cond: (unique1 < 50)`
`292`	`292`	`-> Index Scan using tenk2_unique2 on tenk2 t2`
`293`	`293`	`(cost=0.00..3.01 rows=1 width=148)`
`294`		`- (actual time=0.29..0.32 rows=1 loops=50)`
	`294`	`+ (actual time=0.295..0.324 rows=1 loops=50)`
`295`	`295`	`Index Cond: ("outer".unique2 = t2.unique2)`
`296`		`- Total runtime: 31.60 msec`
	`296`	`+ Total runtime: 31.604 ms`
`297`	`297`	`</screen>`
`298`	`298`
`299`	`299`	`Note that the <quote>actual time</quote> values are in milliseconds of`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`<!--`
`2`		`-$Header: /cvsroot/pgsql/doc/src/sgml/ref/explain.sgml,v 1.30 2003/09/12 00:12:47 tgl Exp $`
	`2`	`+$Header: /cvsroot/pgsql/doc/src/sgml/ref/explain.sgml,v 1.31 2003/10/17 01:14:26 tgl Exp $`
`3`	`3`	`PostgreSQL documentation`
`4`	`4`	`-->`
`5`	`5`
`@@ -210,10 +210,10 @@ EXPLAIN ANALYZE EXECUTE query(100, 200);`
`210`	`210`
`211`	`211`	`QUERY PLAN`
`212`	`212`	`-------------------------------------------------------------------------------------------------------------------------`
`213`		`- HashAggregate (cost=39.53..39.53 rows=1 width=8) (actual time=0.66..0.67 rows=7 loops=1)`
`214`		`- -> Index Scan using test_pkey on test (cost=0.00..32.97 rows=1311 width=8) (actual time=0.05..0.39 rows=99 loops=1)`
	`213`	`+ HashAggregate (cost=39.53..39.53 rows=1 width=8) (actual time=0.661..0.672 rows=7 loops=1)`
	`214`	`+ -> Index Scan using test_pkey on test (cost=0.00..32.97 rows=1311 width=8) (actual time=0.050..0.395 rows=99 loops=1)`
`215`	`215`	`Index Cond: ((id > $1) AND (id < $2))`
`216`		`- Total runtime: 0.85 msec`
	`216`	`+ Total runtime: 0.851 ms`
`217`	`217`	`(4 rows)`
`218`	`218`	`</programlisting>`
`219`	`219`	`</para>`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1994-5, Regents of the University of California`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/commands/explain.c,v 1.116 2003/09/25 18:58:35 tgl Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/explain.c,v 1.117 2003/10/17 01:14:26 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -270,7 +270,7 @@ ExplainOnePlan(QueryDesc queryDesc, ExplainStmt stmt,`
`270`	`270`	`if (es->printCost)`
`271`	`271`	`{`
`272`	`272`	`if (stmt->analyze)`
`273`		`-appendStringInfo(str,"Total runtime: %.2f msec\n",`
	`273`	`+appendStringInfo(str,"Total runtime: %.3f ms\n",`
`274`	`274`	`1000.0*totaltime);`
`275`	`275`	`do_text_output_multiline(tstate,str->data);`
`276`	`276`	`}`
`@@ -582,7 +582,7 @@ explain_outNode(StringInfo str,`
`582`	`582`	`{`
`583`	`583`	`doublenloops=planstate->instrument->nloops;`
`584`	`584`
`585`		`-appendStringInfo(str," (actual time=%.2f..%.2f rows=%.0f loops=%.0f)",`
	`585`	`+appendStringInfo(str," (actual time=%.3f..%.3f rows=%.0f loops=%.0f)",`
`586`	`586`	`1000.0*planstate->instrument->startup /nloops,`
`587`	`587`	`1000.0*planstate->instrument->total /nloops,`
`588`	`588`	`planstate->instrument->ntuples /nloops,`

Comments

(0)