NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfdf2885

committed

Don't call PageGetSpecialPointer() on page until it's been initialized.

After calling XLogInitBufferForRedo(), the page might be all-zeros if it wasnot in page cache already. btree_xlog_unlink_page initialized the pagecorrectly, but it called PageGetSpecialPointer before initializing it, whichwould lead to a corrupt page at WAL replay, if the unlinked page is not inpage cache.Backpatch to 9.4, the bug came with the rewrite of B-tree page deletion.

1 parentb48ecf8 commitfdf2885Copy full SHA for fdf2885

File tree

1 file changed

-1

lines changed

src/backend/access/nbtree
- nbtxlog.c

1 file changed

-1

lines changed

`‎src/backend/access/nbtree/nbtxlog.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -864,9 +864,10 @@ btree_xlog_unlink_page(uint8 info, XLogReaderState *record)`
`864`	`864`
`865`	`865`	`buffer=XLogInitBufferForRedo(record,3);`
`866`	`866`	`page= (Page)BufferGetPage(buffer);`
`867`		`-pageop= (BTPageOpaque)PageGetSpecialPointer(page);`
`868`	`867`
`869`	`868`	`_bt_pageinit(page,BufferGetPageSize(buffer));`
	`869`	`+pageop= (BTPageOpaque)PageGetSpecialPointer(page);`
	`870`	`+`
`870`	`871`	`pageop->btpo_flags=BTP_HALF_DEAD \|BTP_LEAF;`
`871`	`872`	`pageop->btpo_prev=xlrec->leafleftsib;`
`872`	`873`	`pageop->btpo_next=xlrec->leafrightsib;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfdf2885

File tree

1 file changed

1 file changed

`‎src/backend/access/nbtree/nbtxlog.c`

0 commit comments