NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfdbb979

committed

Backpatch tuplesort.c assertion.

Backpatch an assertion (that was originally added to Postgres 12 bycommitdd299df) that seems broadly useful. The assertion can detectviolations of the HOT invariant (i.e. no two index tuples can point tothe same heap TID) when CREATE INDEX somehow incorrectly allows that totake place.For example, a IndexBuildHeapScan/heapam_index_build_range_scan bugmight result in two tuples that both point to the same heap TID. Ifthese two tuples also happen to be duplicates, the assertion will fail.Discussion:https://postgr.es/m/CAH2-WzmBxu4o=pMsniur+bwHqCGCmV_AOLkuK6BuU7ngA6evqw@mail.gmail.comBackpatch: 9.5-11 only

1 parent9729f99 commitfdbb979Copy full SHA for fdbb979

File tree

1 file changed

-0

lines changed

src/backend/utils/sort
- tuplesort.c

1 file changed

-0

lines changed

`‎src/backend/utils/sort/tuplesort.c`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4173,6 +4173,9 @@ comparetup_index_btree(const SortTuple a, const SortTuple b,`
`4173`	`4173`	`return (pos1<pos2) ?-1 :1;`
`4174`	`4174`	`}`
`4175`	`4175`
	`4176`	`+/* ItemPointer values should never be equal */`
	`4177`	`+Assert(false);`
	`4178`	`+`
`4176`	`4179`	`return0;`
`4177`	`4180`	`}`
`4178`	`4181`
`@@ -4225,6 +4228,9 @@ comparetup_index_hash(const SortTuple a, const SortTuple b,`
`4225`	`4228`	`return (pos1<pos2) ?-1 :1;`
`4226`	`4229`	`}`
`4227`	`4230`
	`4231`	`+/* ItemPointer values should never be equal */`
	`4232`	`+Assert(false);`
	`4233`	`+`
`4228`	`4234`	`return0;`
`4229`	`4235`	`}`
`4230`	`4236`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfdbb979

File tree

1 file changed

1 file changed

`‎src/backend/utils/sort/tuplesort.c`

0 commit comments