NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfd80c10

committed

There are errors in the PGmoney class in the conversion routines over

the handling of negative numbers and commas. The attached path attemptsto fix these.However the getValue method does not yet insert commas into thegenerated string.Also in getValue there is an incorrect assumption that the currencysymbol is '$', it should of course be '£'!. I have no idea on how to goabout fixing this one.Alvin

1 parent817a3e6 commitfd80c10Copy full SHA for fd80c10

File tree

1 file changed

+22

-2

lines changed

src/interfaces/jdbc/postgresql/util
- PGmoney.java

1 file changed

+22

-2

lines changed

`‎src/interfaces/jdbc/postgresql/util/PGmoney.java`

Lines changed: 22 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,22 @@ public PGmoney()`
`48`	`48`	`publicvoidsetValue(Strings)throwsSQLException`
`49`	`49`	`{`
`50`	`50`	`try {`
`51`		`-val =Double.valueOf(s.substring(1)).doubleValue();`
	`51`	`+Strings1;`
	`52`	`+booleannegative;`
	`53`	`+`
	`54`	`+negative = (s.charAt(0) =='-') ;`
	`55`	`+`
	`56`	`+s1 =s.substring(negative ?2 :1);`
	`57`	`+`
	`58`	`+intpos =s1.indexOf(',');`
	`59`	`+while (pos != -1) {`
	`60`	`+s1 =s1.substring(0,pos) +s1.substring(pos +1);`
	`61`	`+pos =s1.indexOf(',');`
	`62`	`+ }`
	`63`	`+`
	`64`	`+val =Double.valueOf(s1).doubleValue();`
	`65`	`+val =negative ? -val :val;`
	`66`	`+`
`52`	`67`	`}catch(NumberFormatExceptione) {`
`53`	`68`	`thrownewSQLException("conversion of money failed - "+e.toString());`
`54`	`69`	`}`
`@@ -80,6 +95,11 @@ public Object clone()`
`80`	`95`	`*/`
`81`	`96`	`publicStringgetValue()`
`82`	`97`	`{`
`83`		`-return"$"+val;`
	`98`	`+if (val <0) {`
	`99`	`+return"-$" + (-val);`
	`100`	`+ }`
	`101`	`+else {`
	`102`	`+return"$"+val;`
	`103`	`+ }`
`84`	`104`	`}`
`85`	`105`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfd80c10

File tree

1 file changed

1 file changed

`‎src/interfaces/jdbc/postgresql/util/PGmoney.java`

0 commit comments