Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitfd3dfc2

Browse files
committed
Use a fd opened for read/write when syncing slots during startup.
Some operating systems, including the reporter's windows, return EBADFDor similar when fsync() is invoked on a O_RDONLY file descriptor.Unfortunately RestoreSlotFromDisk() does exactly that; which causesfailures after restarts in at least some scenarios.If you hit the bug the error message will be something likeERROR: could not fsync file "pg_replslot/$name/state": Bad file descriptorSimply use O_RDWR instead of O_RDONLY when opening the relevant filedescriptor to fix the bug. Unfortunately I have no way of verifying thefix, but we've seen similar problems in the past.This bug goes back to 9.4 where slots were introduced. Backpatchaccordingly.Reported-By: Patrice DroletBug: #13143:Discussion: 20150424101006.2556.60897@wrigleys.postgresql.org
1 parent5f3d190 commitfd3dfc2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎src/backend/replication/slot.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1091,7 +1091,7 @@ RestoreSlotFromDisk(const char *name)
10911091

10921092
elog(DEBUG1,"restoring replication slot from \"%s\"",path);
10931093

1094-
fd=OpenTransientFile(path,O_RDONLY |PG_BINARY,0);
1094+
fd=OpenTransientFile(path,O_RDWR |PG_BINARY,0);
10951095

10961096
/*
10971097
* We do not need to handle this as we are rename()ing the directory into

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp