Commitfd1ac9a

committed

Make compression.sql regression test independent of default.

This test will fail in "make installcheck" if the installation'sdefault_toast_compression setting is not 'pglz'. Make it robustagainst that situation.Dilip KumarDiscussion:https://postgr.es/m/CAFiTN-t0w+Rc2U3S+y=7KWcLuOYNB5MfWeGdNa7+pg0UovVdcQ@mail.gmail.com

1 parentef82387 commitfd1ac9aCopy full SHA for fd1ac9a

File tree

+10

-0

lines changed

+10

-0

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,6 @@`
`1`	`1`	`\set HIDE_TOAST_COMPRESSION false`
	`2`	`+-- ensure we get stable results regardless of installation's default`
	`3`	`+SET default_toast_compression = 'pglz';`
`2`	`4`	`-- test creating table with compression method`
`3`	`5`	`CREATE TABLE cmdata(f1 text COMPRESSION pglz);`
`4`	`6`	`CREATE INDEX idx ON cmdata(f1);`
`@@ -245,6 +247,7 @@ CREATE TABLE cmdata2 (f1 text);`
`245`	`247`	`--------+------+-----------+----------+---------+----------+-------------+--------------+-------------`
`246`	`248`	`f1 \| text \| \| \| \| extended \| lz4 \| \|`
`247`	`249`
	`250`	`+SET default_toast_compression = 'pglz';`
`248`	`251`	`-- test alter compression method`
`249`	`252`	`ALTER TABLE cmdata ALTER COLUMN f1 SET COMPRESSION lz4;`
`250`	`253`	`INSERT INTO cmdata VALUES (repeat('123456789', 4004));`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,6 @@`
`1`	`1`	`\set HIDE_TOAST_COMPRESSION false`
	`2`	`+-- ensure we get stable results regardless of installation's default`
	`3`	`+SET default_toast_compression = 'pglz';`
`2`	`4`	`-- test creating table with compression method`
`3`	`5`	`CREATE TABLE cmdata(f1 text COMPRESSION pglz);`
`4`	`6`	`CREATE INDEX idx ON cmdata(f1);`
`@@ -241,6 +243,7 @@ CREATE TABLE cmdata2 (f1 text);`
`241`	`243`	`--------+------+-----------+----------+---------+----------+-------------+--------------+-------------`
`242`	`244`	`f1 \| text \| \| \| \| extended \| pglz \| \|`
`243`	`245`
	`246`	`+SET default_toast_compression = 'pglz';`
`244`	`247`	`-- test alter compression method`
`245`	`248`	`ALTER TABLE cmdata ALTER COLUMN f1 SET COMPRESSION lz4;`
`246`	`249`	`ERROR: unsupported LZ4 compression method`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,8 @@`
`1`	`1`	`\set HIDE_TOAST_COMPRESSION false`
`2`	`2`
	`3`	`+-- ensure we get stable results regardless of installation's default`
	`4`	`+SET default_toast_compression='pglz';`
	`5`	`+`
`3`	`6`	`-- test creating table with compression method`
`4`	`7`	`CREATETABLEcmdata(f1text COMPRESSION pglz);`
`5`	`8`	`CREATEINDEXidxON cmdata(f1);`
`@@ -100,6 +103,7 @@ SET default_toast_compression = 'lz4';`
`100`	`103`	`DROPTABLE cmdata2;`
`101`	`104`	`CREATETABLEcmdata2 (f1text);`
`102`	`105`	`\d+ cmdata2`
	`106`	`+SET default_toast_compression='pglz';`
`103`	`107`
`104`	`108`	`-- test alter compression method`
`105`	`109`	`ALTERTABLE cmdata ALTER COLUMN f1SET COMPRESSION lz4;`

Comments

(0)