forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitfce6fd5
committed
Fix MinGW %d vs %lu warnings in back branches.
Commit352f6f2 used %d instead of %lu to format DWORD (unsigned long)with psprintf(). The _WIN32_WINNT value recently changed for MinGW inREL_15_STABLE (commitd700e8d), so the code was suddenly beingcompiled, with warnings from gcc.The warnings were already fixed in 16+ by commits495ed0e anda9bc04bafter the _WIN32_WINNT value was increase there. 14 and 13 didn't warnbecause they still use a lower value for MinGW, and supported versionsof Visual Studio should compile the code in all live branches but don'tcheck our format string.The change doesn't affect the result: sizeof(int) == sizeof(long) onthis platform, and the values are computed with expressions that cannotexceed INT_MAX so were never interpreted as negative.Back-patch the formatting change from those commits into 13-15. Thisshould turn CI's 15 branch green again and stop fairywren from warningabout that on 15.Reported-by: Andres Freund <andres@anarazel.de>Reported-by: Peter Eisentraut <peter@eisentraut.org>Discussion:https://postgr.es/m/t2vjrcb3bloxf5qqvxjst6r7lvrefqyecxgt2koy5ho5b5glr2%40yuupmm6whgob1 parentaa663d3 commitfce6fd5
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1759 | 1759 | | |
1760 | 1760 | | |
1761 | 1761 | | |
1762 | | - | |
| 1762 | + | |
1763 | 1763 | | |
1764 | 1764 | | |
1765 | 1765 | | |
| |||
0 commit comments
Comments
(0)