NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfcdb35c

committed

Fix transformJsonBehavior

Commit1a36bc9 conained some logic that was a little opaque andcould have involved a NULL dereference, as complained about by Coverity.Make the logic more transparent and in doing so avoid the NULLdereference.

1 parentcd4868a commitfcdb35cCopy full SHA for fcdb35c

File tree

1 file changed

-6

lines changed

src/backend/parser
- parse_expr.c

1 file changed

-6

lines changed

`‎src/backend/parser/parse_expr.c`

Lines changed: 8 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -4072,13 +4072,15 @@ static JsonBehavior *`
`4072`	`4072`	`transformJsonBehavior(ParseStatepstate,JsonBehaviorbehavior,`
`4073`	`4073`	`JsonBehaviorTypedefault_behavior)`
`4074`	`4074`	`{`
`4075`		`-JsonBehaviorTypebehavior_type;`
`4076`		`-Node*default_expr;`
`4077`		`-`
`4078`		`-behavior_type=behavior ?behavior->btype :default_behavior;`
`4079`		`-default_expr=behavior_type!=JSON_BEHAVIOR_DEFAULT ?NULL :`
`4080`		`-transformExprRecurse(pstate,behavior->default_expr);`
	`4075`	`+JsonBehaviorTypebehavior_type=default_behavior;`
	`4076`	`+Node*default_expr=NULL;`
`4081`	`4077`
	`4078`	`+if (behavior)`
	`4079`	`+{`
	`4080`	`+behavior_type=behavior->btype;`
	`4081`	`+if (behavior_type==JSON_BEHAVIOR_DEFAULT)`
	`4082`	`+default_expr=transformExprRecurse(pstate,behavior->default_expr);`
	`4083`	`+}`
`4082`	`4084`	`returnmakeJsonBehavior(behavior_type,default_expr);`
`4083`	`4085`	`}`
`4084`	`4086`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfcdb35c

File tree

1 file changed

1 file changed

`‎src/backend/parser/parse_expr.c`

0 commit comments