NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfcd77a6

committed

Fix minor memory leaks in pg_dump.

Coverity reported the two oversights in getPublicationTables.Valgrind found the one in determineNotNullFlags.The mistakes in getPublicationTables seem too minor to be worthback-patching. determineNotNullFlags could be run enough timesto matter, but that code is new in v18. So, no back-patch.

1 parentc45963c commitfcd77a6Copy full SHA for fcd77a6

File tree

1 file changed

-0

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-0

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4682,6 +4682,8 @@ getPublicationTables(Archive *fout, TableInfo tblinfo[], int numTables)`
`4682`	`4682`	`appendPQExpBufferStr(attribs, fmtId(attnames[k]));`
`4683`	`4683`	`}`
`4684`	`4684`	`pubrinfo[j].pubrattrs = attribs->data;`
	`4685`	`+free(attribs);/* but not attribs->data */`
	`4686`	`+free(attnames);`
`4685`	`4687`	`}`
`4686`	`4688`	`else`
`4687`	`4689`	`pubrinfo[j].pubrattrs = NULL;`
`@@ -9424,6 +9426,7 @@ determineNotNullFlags(Archive fout, PGresult res, int r,`
`9424`	`9426`	`tbinfo->notnull_constrs[j] =`
`9425`	`9427`	`pstrdup(PQgetvalue(res, r, i_notnull_name));`
`9426`	`9428`	`}`
	`9429`	`+free(default_name);`
`9427`	`9430`	`}`
`9428`	`9431`	`}`
`9429`	`9432`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfcd77a6

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments