Commitfcbd1bb

committed

Reduce variable scope and possibly useless palloc

Move the CreateStmt down to the branch that it's used in, thuspreventing the makeNode() call in cases where the CreateStmt isn't used.Author: Ranier Vilela <ranier.vf@gmail.com>Discussion:https://postgr.es/m/CAEudQAq=06YPWPhS+yyTbCwv5JLKRz8rm3dWx6JR5Uj_d_fQDA@mail.gmail.com

1 parent84b8fcc commitfcbd1bbCopy full SHA for fcbd1bb

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,6 @@ DefineVirtualRelation(RangeVar relation, List tlist, bool replace,`
`47`	`47`	`{`
`48`	`48`	`OidviewOid;`
`49`	`49`	`LOCKMODElockmode;`
`50`		`-CreateStmt*createStmt=makeNode(CreateStmt);`
`51`	`50`	`List*attrList;`
`52`	`51`	`ListCell*t;`
`53`	`52`
`@@ -223,6 +222,7 @@ DefineVirtualRelation(RangeVar relation, List tlist, bool replace,`
`223`	`222`	`}`
`224`	`223`	`else`
`225`	`224`	`{`
	`225`	`+CreateStmt*createStmt=makeNode(CreateStmt);`
`226`	`226`	`ObjectAddressaddress;`
`227`	`227`
`228`	`228`	`/*`

Comments

(0)