NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfca17a9

committed

Fix local/remote attribute mix-up in logical replication

This would lead to failures if local and remote tables have a differentcolumn order. The tests previously didn't catch that because they onlytested the initial data copy. So add another test that exercises theapply worker.Author: Petr Jelinek <petr.jelinek@2ndquadrant.com>

1 parent0e58455 commitfca17a9Copy full SHA for fca17a9

File tree

2 files changed

-2

lines changed

src
- backend/replication/logical
  - worker.c
- test/subscription/t
  - 001_rep_changes.pl

2 files changed

-2

lines changed

`‎src/backend/replication/logical/worker.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -402,7 +402,8 @@ slot_modify_cstrings(TupleTableSlot slot, LogicalRepRelMapEntry rel,`
`402`	`402`	`errarg.attnum=remoteattnum;`
`403`	`403`
`404`	`404`	`getTypeInputInfo(att->atttypid,&typinput,&typioparam);`
`405`		`-slot->tts_values[i]=OidInputFunctionCall(typinput,values[i],`
	`405`	`+slot->tts_values[i]=OidInputFunctionCall(typinput,`
	`406`	`+values[remoteattnum],`
`406`	`407`	`typioparam,`
`407`	`408`	`att->atttypmod);`
`408`	`409`	`slot->tts_isnull[i]= false;`

`‎src/test/subscription/t/001_rep_changes.pl`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,8 @@`
`89`	`89`	`$node_publisher->safe_psql('postgres',"DELETE FROM tab_rep WHERE a > 20");`
`90`	`90`	`$node_publisher->safe_psql('postgres',"UPDATE tab_rep SET a = -a");`
`91`	`91`
	`92`	`+$node_publisher->safe_psql('postgres',"INSERT INTO tab_mixed VALUES (2, 'bar')");`
	`93`	`+`
`92`	`94`	`$node_publisher->poll_query_until('postgres',$caughtup_query)`
`93`	`95`	`ordie"Timed out while waiting for subscriber to catch up";`
`94`	`96`
`@@ -102,7 +104,8 @@`
`102`	`104`
`103`	`105`	`$result =$node_subscriber->safe_psql('postgres',`
`104`	`106`	`"SELECT c, b, a FROM tab_mixed");`
`105`		`-is($result,qq(\|foo\|1),'check replicated changes with different column order');`
	`107`	`+is($result,qq(\|foo\|1`
	`108`	`+\|bar\|2),'check replicated changes with different column order');`
`106`	`109`
`107`	`110`	`# insert some duplicate rows`
`108`	`111`	`$node_publisher->safe_psql('postgres',`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfca17a9

File tree

2 files changed

2 files changed

`‎src/backend/replication/logical/worker.c`

`‎src/test/subscription/t/001_rep_changes.pl`

0 commit comments