forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitfc8b81a
committed
Need to do SPI_push/SPI_pop around expression evaluation in plpgsql.
We must do this in case the expression evaluation results in callinganother plpgsql function (or, really, anything using SPI). I missedthe need for this when I converted exec_cast_value() from doing asimple InputFunctionCall() to doing ExecEvalExpr() in commit1345cc6.There is a SPI_push_conditional in InputFunctionCall(), so that therewas no bug before that.Per bug #14414 from Marcos Castedo. Add a regression test based on hisexample, which was that a plpgsql function in a domain check constraintdidn't work when assigning to a domain-type variable within plpgsql.Report: <20161106010947.1387.66380@wrigleys.postgresql.org>1 parent5485c99 commitfc8b81a
File tree
3 files changed
+45
-0
lines changed- src
- pl/plpgsql/src
- test/regress
- expected
- sql
3 files changed
+45
-0
lines changedLines changed: 4 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
6300 | 6300 |
| |
6301 | 6301 |
| |
6302 | 6302 |
| |
| 6303 | + | |
| 6304 | + | |
6303 | 6305 |
| |
6304 | 6306 |
| |
6305 | 6307 |
| |
| |||
6313 | 6315 |
| |
6314 | 6316 |
| |
6315 | 6317 |
| |
| 6318 | + | |
| 6319 | + | |
6316 | 6320 |
| |
6317 | 6321 |
| |
6318 | 6322 |
| |
|
Lines changed: 19 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
5643 | 5643 |
| |
5644 | 5644 |
| |
5645 | 5645 |
| |
| 5646 | + | |
| 5647 | + | |
| 5648 | + | |
| 5649 | + | |
| 5650 | + | |
| 5651 | + | |
| 5652 | + | |
| 5653 | + | |
| 5654 | + | |
| 5655 | + | |
| 5656 | + | |
| 5657 | + | |
| 5658 | + | |
| 5659 | + | |
| 5660 | + | |
| 5661 | + | |
| 5662 | + | |
| 5663 | + | |
| 5664 | + |
Lines changed: 22 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
4428 | 4428 |
| |
4429 | 4429 |
| |
4430 | 4430 |
| |
| 4431 | + | |
| 4432 | + | |
| 4433 | + | |
| 4434 | + | |
| 4435 | + | |
| 4436 | + | |
| 4437 | + | |
| 4438 | + | |
| 4439 | + | |
| 4440 | + | |
| 4441 | + | |
| 4442 | + | |
| 4443 | + | |
| 4444 | + | |
| 4445 | + | |
| 4446 | + | |
| 4447 | + | |
| 4448 | + | |
| 4449 | + | |
| 4450 | + | |
| 4451 | + | |
| 4452 | + |
0 commit comments
Comments
(0)