forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitfc8219d
committed
pageinspect: Fix hash_bitmap_info not to read the underlying page.
It did that to verify that the page was an overflow page rather thananything else, but that means that checking the status of all theoverflow bits requires reading the entire index. So don't do that.The new code validates that the page is not a primary bucket pageor bitmap page by looking at the metapage, so that using this onlarge numbers of pages can be reasonably efficient.Ashutosh Sharma, per a complaint from me, and with furthermodifications by me.1 parent86d911e commitfc8219d
File tree
3 files changed
+53
-40
lines changed- contrib/pageinspect
- expected
- src/backend/access/hash
3 files changed
+53
-40
lines changedLines changed: 6 additions & 12 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
30 | 30 |
| |
31 | 31 |
| |
32 | 32 |
| |
33 |
| - | |
34 |
| - | |
| 33 | + | |
35 | 34 |
| |
36 |
| - | |
37 |
| - | |
| 35 | + | |
38 | 36 |
| |
39 |
| - | |
40 |
| - | |
| 37 | + | |
41 | 38 |
| |
42 |
| - | |
43 |
| - | |
| 39 | + | |
44 | 40 |
| |
45 |
| - | |
46 |
| - | |
| 41 | + | |
47 | 42 |
| |
48 |
| - | |
49 |
| - | |
| 43 | + | |
50 | 44 |
| |
51 | 45 |
| |
52 | 46 |
| |
|
Lines changed: 36 additions & 26 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
380 | 380 |
| |
381 | 381 |
| |
382 | 382 |
| |
383 |
| - | |
384 |
| - | |
| 383 | + | |
| 384 | + | |
385 | 385 |
| |
386 |
| - | |
| 386 | + | |
387 | 387 |
| |
388 |
| - | |
389 | 388 |
| |
390 | 389 |
| |
391 | 390 |
| |
392 | 391 |
| |
393 | 392 |
| |
394 | 393 |
| |
395 |
| - | |
| 394 | + | |
| 395 | + | |
396 | 396 |
| |
397 | 397 |
| |
| 398 | + | |
398 | 399 |
| |
399 | 400 |
| |
400 | 401 |
| |
| |||
418 | 419 |
| |
419 | 420 |
| |
420 | 421 |
| |
421 |
| - | |
422 |
| - | |
423 |
| - | |
424 |
| - | |
425 |
| - | |
426 |
| - | |
427 |
| - | |
428 |
| - | |
429 |
| - | |
430 |
| - | |
431 |
| - | |
432 |
| - | |
433 |
| - | |
434 |
| - | |
435 |
| - | |
436 |
| - | |
437 |
| - | |
438 |
| - | |
439 |
| - | |
440 | 422 |
| |
441 | 423 |
| |
442 | 424 |
| |
443 | 425 |
| |
444 |
| - | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
445 | 446 |
| |
446 | 447 |
| |
447 | 448 |
| |
| |||
450 | 451 |
| |
451 | 452 |
| |
452 | 453 |
| |
453 |
| - | |
| 454 | + | |
| 455 | + | |
454 | 456 |
| |
455 | 457 |
| |
456 | 458 |
| |
457 | 459 |
| |
458 | 460 |
| |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
459 | 469 |
| |
460 | 470 |
| |
461 | 471 |
| |
|
Lines changed: 11 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
69 | 69 |
| |
70 | 70 |
| |
71 | 71 |
| |
72 |
| - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
73 | 80 |
| |
74 | 81 |
| |
75 | 82 |
| |
76 |
| - | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
77 | 86 |
| |
78 | 87 |
| |
79 | 88 |
| |
|
0 commit comments
Comments
(0)