NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfc7a5e9

committed

Ensure relcache consistency around generated columns

In certain transient states, it's possible that a table has attributeswith attgenerated set but no default expressions in pg_attrdef yet.In that case, the old code path would not setrelation->rd_att->constr->has_generated_stored, unlessrelation->rd_att->constr was also populated for some other reason.There was probably no practical impact, but it's better to keep thisconsistent.Reported-by: Andres Freund <andres@anarazel.de>Discussion:https://www.postgresql.org/message-id/flat/20200115181105.ad6ab6dlgyww3lb6%40alap3.anarazel.de

1 parent7d4395d commitfc7a5e9Copy full SHA for fc7a5e9

File tree

1 file changed

-2

lines changed

src/backend/utils/cache
- relcache.c

1 file changed

-2

lines changed

`‎src/backend/utils/cache/relcache.c`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -669,8 +669,11 @@ RelationBuildTupleDesc(Relation relation)`
`669`	`669`	`/*`
`670`	`670`	`* Set up constraint/default info`
`671`	`671`	`*/`
`672`		`-if (constr->has_not_null\|\|ndef>0\|\|`
`673`		`-attrmiss\|\|relation->rd_rel->relchecks)`
	`672`	`+if (constr->has_not_null\|\|`
	`673`	`+constr->has_generated_stored\|\|`
	`674`	`+ndef>0\|\|`
	`675`	`+attrmiss\|\|`
	`676`	`+relation->rd_rel->relchecks)`
`674`	`677`	`{`
`675`	`678`	`relation->rd_att->constr=constr;`
`676`	`679`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfc7a5e9

File tree

1 file changed

1 file changed

`‎src/backend/utils/cache/relcache.c`

0 commit comments