NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfc3f445

committed

Recompute stack base in forked postmaster children.

This is for the benefit of running postgres under the rrdebugger. When using rr signal handlers running while a syscall isactive use an alternative stack. As e.g. bgworkers are started fromwithin signal handlers, the forked backend then has a different stackbase than postmaster. Previously that subsequently lead to thoseprocesses triggering spurious "stack depth limit exceeded" errors.Discussion:https://postgr.es/m/20200327182217.ubrrl32lyfhxfwk5@alap3.anarazel.de

1 parentf946069 commitfc3f445Copy full SHA for fc3f445

File tree

2 files changed

-5

lines changed

src/backend
- postmaster
  - postmaster.c
- utils/init
  - miscinit.c

2 files changed

-5

lines changed

`‎src/backend/postmaster/postmaster.c`

Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -4900,11 +4900,6 @@ SubPostmasterMain(int argc, char *argv[])`
`4900`	`4900`	`/* Close the postmaster's sockets (as soon as we know them) */`
`4901`	`4901`	`ClosePostmasterPorts(strcmp(argv[1],"--forklog")==0);`
`4902`	`4902`
`4903`		`-/*`
`4904`		`- * Set reference point for stack-depth checking`
`4905`		`- */`
`4906`		`-set_stack_base();`
`4907`		`-`
`4908`	`4903`	`/*`
`4909`	`4904`	`* Set up memory area for GSS information. Mirrors the code in ConnCreate`
`4910`	`4905`	`* for the non-exec case.`

`‎src/backend/utils/init/miscinit.c`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,15 @@ InitPostmasterChild(void)`
`92`	`92`	`{`
`93`	`93`	`IsUnderPostmaster= true;/* we are a postmaster subprocess now */`
`94`	`94`
	`95`	`+/*`
	`96`	`+ * Set reference point for stack-depth checking. We re-do that even in the`
	`97`	`+ * !EXEC_BACKEND case, because there are some edge cases where processes`
	`98`	`+ * are started with an alternative stack (e.g. starting bgworkers when`
	`99`	`+ * running postgres using the rr debugger, as bgworkers are launched from`
	`100`	`+ * signal handlers).`
	`101`	`+ */`
	`102`	`+set_stack_base();`
	`103`	`+`
`95`	`104`	`InitProcessGlobals();`
`96`	`105`
`97`	`106`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfc3f445

File tree

2 files changed

2 files changed

`‎src/backend/postmaster/postmaster.c`

`‎src/backend/utils/init/miscinit.c`

0 commit comments