NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfc3297d

committed

Make heap_update() set newtup->t_tableOid correctly, for consistency with

the other major heapam.c functions. The only known consequence of thisomission is that UPDATE RETURNING failed to return the correct value for"tableoid", as per report from KaiGai Kohei.Back-patch to 8.2. Arguably it's wrong all the way back; but withoutevidence of visible breakage before RETURNING was added, I'll desist frompatching the older branches.

1 parent04ecc64 commitfc3297dCopy full SHA for fc3297d

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- heapam.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/heapam.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/access/heap/heapam.c,v 1.271 2008/12/03 13:05:22 heikki Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/access/heap/heapam.c,v 1.272 2008/12/16 16:26:08 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*`
`14`	`14`	`* INTERFACE ROUTINES`
`@@ -2604,6 +2604,7 @@ heap_update(Relation relation, ItemPointer otid, HeapTuple newtup,`
`2604`	`2604`	`HeapTupleHeaderSetXmin(newtup->t_data,xid);`
`2605`	`2605`	`HeapTupleHeaderSetCmin(newtup->t_data,cid);`
`2606`	`2606`	`HeapTupleHeaderSetXmax(newtup->t_data,0);/* for cleanliness */`
	`2607`	`+newtup->t_tableOid=RelationGetRelid(relation);`
`2607`	`2608`
`2608`	`2609`	`/*`
`2609`	`2610`	`* Replace cid with a combo cid if necessary. Note that we already put`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfc3297d

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c`

0 commit comments