NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfc31001

committed

Remove redundant incomplete split assertion.

The fastpath insert optimization's incomplete split flag Assert() isredundant. We'll reach the more general Assert() within_bt_findinsertloc() in all cases. (Besides, Assert()'ing that therightmost page doesn't have the flag set never made much sense.)

1 parent8c081a2 commitfc31001Copy full SHA for fc31001

File tree

1 file changed

-5

lines changed

src/backend/access/nbtree
- nbtinsert.c

1 file changed

-5

lines changed

`‎src/backend/access/nbtree/nbtinsert.c`

Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -179,11 +179,6 @@ _bt_doinsert(Relation rel, IndexTuple itup,`
`179`	`179`	`PageGetMaxOffsetNumber(page) >=P_FIRSTDATAKEY(lpageop)&&`
`180`	`180`	`_bt_compare(rel,itup_key,page,P_FIRSTDATAKEY(lpageop))>0)`
`181`	`181`	`{`
`182`		`-/*`
`183`		`- * The right-most block should never have an incomplete split.`
`184`		`- * But be paranoid and check for it anyway.`
`185`		`- */`
`186`		`-Assert(!P_INCOMPLETE_SPLIT(lpageop));`
`187`	`182`	`fastpath= true;`
`188`	`183`	`}`
`189`	`184`	`else`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfc31001

File tree

1 file changed

1 file changed

`‎src/backend/access/nbtree/nbtinsert.c`

0 commit comments