NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfbe9b80

committed

Fix autovacuum log output heap truncation issue.

The percentage of blocks from the table value reported by autovacuum logoutput (following commit5100010) should never exceed 100% becauseit describes the state of the table back when lazy_vacuum() was called.The value could nevertheless exceed 100% in the event of heap relationtruncation. We failed to compensate for how truncation affectsrel_pages.Fix the faulty accounting by using the original rel_pages value insteadof the current/final rel_pages value.Reported-By: Andres Freund <andres@anarazel.de>Discussion:https://postgr.es/m/20210423204306.5osfpkt2ggaedyvy@alap3.anarazel.de

1 parentb2d0c7c commitfbe9b80Copy full SHA for fbe9b80

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- vacuumlazy.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/vacuumlazy.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -777,6 +777,8 @@ heap_vacuum_rel(Relation rel, VacuumParams *params,`
`777`	`777`	`(long long)VacuumPageDirty);`
`778`	`778`	`if (vacrel->rel_pages>0)`
`779`	`779`	`{`
	`780`	`+BlockNumberorig_rel_pages;`
	`781`	`+`
`780`	`782`	`if (vacrel->do_index_vacuuming)`
`781`	`783`	`{`
`782`	`784`	`msgfmt=_(" %u pages from table (%.2f%% of total) had %lld dead item identifiers removed\n");`
`@@ -795,9 +797,10 @@ heap_vacuum_rel(Relation rel, VacuumParams *params,`
`795`	`797`	`else`
`796`	`798`	`appendStringInfo(&buf,_("index scan bypassed by failsafe:"));`
`797`	`799`	`}`
	`800`	`+orig_rel_pages=vacrel->rel_pages+vacrel->pages_removed;`
`798`	`801`	`appendStringInfo(&buf,msgfmt,`
`799`	`802`	`vacrel->lpdead_item_pages,`
`800`		`-100.0*vacrel->lpdead_item_pages /vacrel->rel_pages,`
	`803`	`+100.0*vacrel->lpdead_item_pages /orig_rel_pages,`
`801`	`804`	`(long long)vacrel->lpdead_items);`
`802`	`805`	`}`
`803`	`806`	`for (inti=0;i<vacrel->nindexes;i++)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfbe9b80

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/vacuumlazy.c`

0 commit comments