NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfb9042f

committed

Reduce recursion depth in recently-added regression test.

Some buildfarm members fail the test with the original depth of 10 levels,apparently because they are running at the minimum max_stack_depth settingof 100kB and using ~ 10k per recursion level. While it might beinteresting to try to figure out why they're eating so much stack, it isn'tlikely that any fix for that would be back-patchable. So just change thetest to recurse only 5 levels. The extra levels don't prove anythingcorrectness-wise anyway.

1 parent3f36070 commitfb9042fCopy full SHA for fb9042f

File tree

2 files changed

-7

lines changed

src/test/regress
- expected
  - plpgsql.out
- sql
  - plpgsql.sql

2 files changed

-7

lines changed

`‎src/test/regress/expected/plpgsql.out`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -3967,8 +3967,8 @@ DROP FUNCTION nonsimple_expr_test();`
`3967`	`3967`	`create function recurse(float8) returns float8 as`
`3968`	`3968`	`$$`
`3969`	`3969`	`begin`
`3970`		`- if ($1< 10) then`
`3971`		`- return sql_recurse($1+ 1);`
	`3970`	`+ if ($1> 0) then`
	`3971`	`+ return sql_recurse($1- 1);`
`3972`	`3972`	`else`
`3973`	`3973`	`return $1;`
`3974`	`3974`	`end if;`
`@@ -3977,10 +3977,10 @@ $$ language plpgsql;`
`3977`	`3977`	`-- "limit" is to prevent this from being inlined`
`3978`	`3978`	`create function sql_recurse(float8) returns float8 as`
`3979`	`3979`	`$$ select recurse($1) limit 1; $$ language sql;`
`3980`		`-select recurse(0);`
	`3980`	`+select recurse(5);`
`3981`	`3981`	`recurse`
`3982`	`3982`	`---------`
`3983`		`-10`
	`3983`	`+ 0`
`3984`	`3984`	`(1 row)`
`3985`	`3985`
`3986`	`3986`	`create function error1(text) returns text language sql as`

`‎src/test/regress/sql/plpgsql.sql`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -3174,8 +3174,8 @@ DROP FUNCTION nonsimple_expr_test();`
`3174`	`3174`	`createfunctionrecurse(float8) returns float8as`
`3175`	`3175`	`$$`
`3176`	`3176`	`begin`
`3177`		`- if ($1<10) then`
`3178`		`- return sql_recurse($1+1);`
	`3177`	`+ if ($1>0) then`
	`3178`	`+ return sql_recurse($1-1);`
`3179`	`3179`	`else`
`3180`	`3180`	`return $1;`
`3181`	`3181`	`end if;`
`@@ -3186,7 +3186,7 @@ $$ language plpgsql;`
`3186`	`3186`	`createfunctionsql_recurse(float8) returns float8as`
`3187`	`3187`	`$$select recurse($1)limit1; $$ language sql;`
`3188`	`3188`
`3189`		`-select recurse(0);`
	`3189`	`+select recurse(5);`
`3190`	`3190`
`3191`	`3191`	`createfunctionerror1(text) returnstext language sqlas`
`3192`	`3192`	`$$SELECT relname::textFROM pg_class cWHEREc.oid= $1::regclass $$;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfb9042f

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/plpgsql.out`

`‎src/test/regress/sql/plpgsql.sql`

0 commit comments