NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfb1132e

committed

Work around spurious compiler warning in inet operators

gcc 12+ has complaints like the following:../../../../../pgsql/src/backend/utils/adt/network.c: In function 'inetnot':../../../../../pgsql/src/backend/utils/adt/network.c:1893:34: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=] 1893 | pdst[nb] = ~pip[nb]; | ~~~~~~~~~^~~~~~~~~~../../../../../pgsql/src/include/utils/inet.h:27:23: note: at offset -1 into destination object 'ipaddr' of size 16 27 | unsigned char ipaddr[16]; /* up to 128 bits of address */ | ^~~~~~../../../../../pgsql/src/include/utils/inet.h:27:23: note: at offset -1 into destination object 'ipaddr' of size 16This is due to a compiler bug:https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104986It has been a year since the bug has been reported without getting fixed. Asthe warnings are verbose and use of gcc 12 is becoming more common, it seemsworth working around the bug. Particularly because a simple reformulation ofthe loop condition fixes the issue and isn't any less readable.Author: Tom Lane <tgl@sss.pgh.pa.us>Author: Andres Freund <andres@anarazel.de>Discussion:https://postgr.es/m/144536.1648326206@sss.pgh.pa.usBackpatch: 11-

1 parent75e7378 commitfb1132eCopy full SHA for fb1132e

File tree

1 file changed

-5

lines changed

src/backend/utils/adt
- network.c

1 file changed

-5

lines changed

`‎src/backend/utils/adt/network.c`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1874,7 +1874,7 @@ inetnot(PG_FUNCTION_ARGS)`
`1874`	`1874`	`unsignedchar*pip=ip_addr(ip);`
`1875`	`1875`	`unsignedchar*pdst=ip_addr(dst);`
`1876`	`1876`
`1877`		`-while (nb-->0)`
	`1877`	`+while (--nb >=0)`
`1878`	`1878`	`pdst[nb]= ~pip[nb];`
`1879`	`1879`	`}`
`1880`	`1880`	`ip_bits(dst)=ip_bits(ip);`
`@@ -1906,7 +1906,7 @@ inetand(PG_FUNCTION_ARGS)`
`1906`	`1906`	`unsignedchar*pip2=ip_addr(ip2);`
`1907`	`1907`	`unsignedchar*pdst=ip_addr(dst);`
`1908`	`1908`
`1909`		`-while (nb-->0)`
	`1909`	`+while (--nb >=0)`
`1910`	`1910`	`pdst[nb]=pip[nb]&pip2[nb];`
`1911`	`1911`	`}`
`1912`	`1912`	`ip_bits(dst)=Max(ip_bits(ip),ip_bits(ip2));`
`@@ -1938,7 +1938,7 @@ inetor(PG_FUNCTION_ARGS)`
`1938`	`1938`	`unsignedchar*pip2=ip_addr(ip2);`
`1939`	`1939`	`unsignedchar*pdst=ip_addr(dst);`
`1940`	`1940`
`1941`		`-while (nb-->0)`
	`1941`	`+while (--nb >=0)`
`1942`	`1942`	`pdst[nb]=pip[nb] \|pip2[nb];`
`1943`	`1943`	`}`
`1944`	`1944`	`ip_bits(dst)=Max(ip_bits(ip),ip_bits(ip2));`
`@@ -1963,7 +1963,7 @@ internal_inetpl(inet *ip, int64 addend)`
`1963`	`1963`	`unsignedchar*pdst=ip_addr(dst);`
`1964`	`1964`	`intcarry=0;`
`1965`	`1965`
`1966`		`-while (nb-->0)`
	`1966`	`+while (--nb >=0)`
`1967`	`1967`	`{`
`1968`	`1968`	`carry=pip[nb]+ (int) (addend&0xFF)+carry;`
`1969`	`1969`	`pdst[nb]= (unsignedchar) (carry&0xFF);`
`@@ -2047,7 +2047,7 @@ inetmi(PG_FUNCTION_ARGS)`
`2047`	`2047`	`unsignedchar*pip2=ip_addr(ip2);`
`2048`	`2048`	`intcarry=1;`
`2049`	`2049`
`2050`		`-while (nb-->0)`
	`2050`	`+while (--nb >=0)`
`2051`	`2051`	`{`
`2052`	`2052`	`intlobyte;`
`2053`	`2053`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfb1132e

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/network.c`

0 commit comments