NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfae55f0

committed

Allow _h_indexbuild() to be interrupted.

When we are building a hash index that is large enough to needpre-sorting (larger than either maintenance_work_mem or NBuffers),the initial sorting phase is interruptible, but the insertionphase wasn't. Add the missing CHECK_FOR_INTERRUPTS().Per bug #18616 from Alexander Lakhin. Back-patch to allsupported branches.Pavel BorisovDiscussion:https://postgr.es/m/18616-acbb9e5caf41e964@postgresql.org

1 parent9a23967 commitfae55f0Copy full SHA for fae55f0

File tree

1 file changed

-0

lines changed

src/backend/access/hash
- hashsort.c

1 file changed

-0

lines changed

`‎src/backend/access/hash/hashsort.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -148,6 +148,9 @@ _h_indexbuild(HSpool *hspool, Relation heapRel)`
`148`	`148`	`/* the tuples are sorted by hashkey, so pass 'sorted' as true */`
`149`	`149`	`_hash_doinsert(hspool->index,itup,heapRel, true);`
`150`	`150`
	`151`	`+/* allow insertion phase to be interrupted, and track progress */`
	`152`	`+CHECK_FOR_INTERRUPTS();`
	`153`	`+`
`151`	`154`	`pgstat_progress_update_param(PROGRESS_CREATEIDX_TUPLES_DONE,`
`152`	`155`	`++tups_done);`
`153`	`156`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfae55f0

File tree

1 file changed

1 file changed

`‎src/backend/access/hash/hashsort.c`

0 commit comments