NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfade4d4

committed

Back-patch addition of stack overflow and interrupt checks for lquery.

Experimentation shows that it's not hard at all to drive theold implementation of "ltree ~ lquery" match to stack overflow,so throw in a check_stack_depth() call, as I just did in HEAD.I wasn't able to make it take a long time, because all thepathological cases I tried hit stack overflow first; butI bet there are some others that do take a long time, so addCHECK_FOR_INTERRUPTS() too.Discussion:https://postgr.es/m/CAP_rww=waX2Oo6q+MbMSiZ9ktdj6eaJj0cQzNu=Ry2cCDij5fw@mail.gmail.com

1 parent4bc3a16 commitfade4d4Copy full SHA for fade4d4

File tree

1 file changed

-0

lines changed

contrib/ltree
- lquery_op.c

1 file changed

-0

lines changed

`‎contrib/ltree/lquery_op.c`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`	`#include<ctype.h>`
`9`	`9`
`10`	`10`	`#include"catalog/pg_collation.h"`
	`11`	`+#include"miscadmin.h"`
`11`	`12`	`#include"utils/formatting.h"`
`12`	`13`	`#include"ltree.h"`
`13`	`14`
`@@ -165,6 +166,12 @@ checkCond(lquery_level curq, int query_numlevel, ltree_level curt, int tree_nu`
`165`	`166`	`lquery_level*prevq=NULL;`
`166`	`167`	`ltree_level*prevt=NULL;`
`167`	`168`
	`169`	`+/* Since this function recurses, it could be driven to stack overflow */`
	`170`	`+check_stack_depth();`
	`171`	`+`
	`172`	`+/* Pathological patterns could take awhile, too */`
	`173`	`+CHECK_FOR_INTERRUPTS();`
	`174`	`+`
`168`	`175`	`if (SomeStack.muse)`
`169`	`176`	`{`
`170`	`177`	`high_pos=SomeStack.high_pos;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfade4d4

File tree

1 file changed

1 file changed

`‎contrib/ltree/lquery_op.c`

0 commit comments