NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfaa0550

committed

Remove rare corner case for data loss when triggering standby server.

If the standby was streaming when trigger file arrives, check also in thearchive for additional WAL files. This is a corner case since it isunlikely that we would trigger a failover while the master is stillavailable and sending data to standby, while at the same time running inarchive mode and also while the streaming standby has fallen behind archive.Someone would eventually be unlucky; we must plug all gaps however small.Fujii Masao

1 parent722bf70 commitfaa0550Copy full SHA for faa0550

File tree

1 file changed

-1

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-1

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -9619,7 +9619,7 @@ XLogPageRead(XLogRecPtr *RecPtr, int emode, bool fetching_ckpt,`
`9619`	`9619`	`* five seconds like in the WAL file polling case below.`
`9620`	`9620`	`*/`
`9621`	`9621`	`if (CheckForStandbyTrigger())`
`9622`		`-gototriggered;`
	`9622`	`+gotoretry;`
`9623`	`9623`
`9624`	`9624`	`/*`
`9625`	`9625`	`* Wait for more WAL to arrive, or timeout to be reached`
`@@ -9886,6 +9886,10 @@ static bool`
`9886`	`9886`	`CheckForStandbyTrigger(void)`
`9887`	`9887`	`{`
`9888`	`9888`	`structstatstat_buf;`
	`9889`	`+staticbooltriggered= false;`
	`9890`	`+`
	`9891`	`+if (triggered)`
	`9892`	`+return true;`
`9889`	`9893`
`9890`	`9894`	`if (TriggerFile==NULL)`
`9891`	`9895`	`return false;`
`@@ -9896,6 +9900,7 @@ CheckForStandbyTrigger(void)`
`9896`	`9900`	`(errmsg("trigger file found: %s",TriggerFile)));`
`9897`	`9901`	`ShutdownWalRcv();`
`9898`	`9902`	`unlink(TriggerFile);`
	`9903`	`+triggered= true;`
`9899`	`9904`	`return true;`
`9900`	`9905`	`}`
`9901`	`9906`	`return false;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfaa0550

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments