NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfa73b37

committed

Close the file descriptor in ApplyLogicalMappingFile

The function was forgetting to close the file descriptor, resultingin failures like this: ERROR: 53000: exceeded maxAllocatedDescs (492) while trying to open file "pg_logical/mappings/map-4000-4eb-1_60DE1E08-5376b5-537c6b" LOCATION: OpenTransientFile, fd.c:2161Simply close the file at the end, and backpatch to 9.4 (where logicaldecoding was introduced). While at it, fix a nearby typo.Discussion:https://www.postgresql.org/message-id/flat/738a590a-2ce5-9394-2bef-7b1caad89b37%402ndquadrant.com

1 parent86d78ef commitfa73b37Copy full SHA for fa73b37

File tree

1 file changed

-1

lines changed

src/backend/replication/logical
- reorderbuffer.c

1 file changed

-1

lines changed

`‎src/backend/replication/logical/reorderbuffer.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3278,11 +3278,13 @@ ApplyLogicalMappingFile(HTAB tuplecid_data, Oid relid, const char fname)`
`3278`	`3278`	`new_ent->combocid=ent->combocid;`
`3279`	`3279`	`}`
`3280`	`3280`	`}`
	`3281`	`+`
	`3282`	`+CloseTransientFile(fd);`
`3281`	`3283`	`}`
`3282`	`3284`
`3283`	`3285`
`3284`	`3286`	`/*`
`3285`		`- * Check whether theTransactionOId 'xid' is in the pre-sorted array 'xip'.`
	`3287`	`+ * Check whether theTransactionOid 'xid' is in the pre-sorted array 'xip'.`
`3286`	`3288`	`*/`
`3287`	`3289`	`staticbool`
`3288`	`3290`	`TransactionIdInArray(TransactionIdxid,TransactionId*xip,Sizenum)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfa73b37

File tree

1 file changed

1 file changed

`‎src/backend/replication/logical/reorderbuffer.c`

0 commit comments